Upgrade wp-prettier to 2.2.1 #27441
Merged
Upgrade wp-prettier to 2.2.1 #27441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.19 MB ℹ️ View Unchanged
|
gziolo
reviewed
Dec 2, 2020
| @@ -2,31 +2,31 @@ export type WPDataFunctionOrGeneratorArray = Array< Function | Generator >; | |||
| export type WPDataFunctionArray = Array< Function >; | |||
|
|
|||
| export interface WPDataAttachedStore { | |||
There was a problem hiding this comment.
Is it using now different indentation than JS? Can we align?
There was a problem hiding this comment.
This looks correct to me @gziolo, the indentation is changes spaces to tabs, I suspect this had been missed by ESLint/Prettier at some point previously:
There was a problem hiding this comment.
Yes, this file previously used spaced and was merely reformatted to tabs. There's been no radical change to how TS files are formatted and there are no differences between JS an TS formatting.
There was a problem hiding this comment.
Now I noticed that tsc uses 4 spaces indentation when generating the *.d.ts files in build-types. That's probably where this formatting originated. And Babel apparently indents with 2 spaces.
There was a problem hiding this comment.
I was browsing this file in the mobile app. I couldn't verify whether it's tabs or spaces, it looked like 2 spaces. Ignore this comment One tab is correct.
|
Hmm, I can't edit my comment on GitHub mobile 🙃 I meant that it would be great to verify if it isn't a breaking change because of linting integration. |
gziolo
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades
wp-prettierto version 2.2.1 of the fork, making it up to date with the latest upstream.I already upgraded Calypso successfully earlier today: Automattic/wp-calypso#47950