Data: add a comment about why we normalize resolvers to objects with fulfill method #25102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fulfill method Also refactors the code to remove too smart destructuring, and removes a stale JSDoc comment.
jsnajdr
added
[Type] Code Quality
|
Size Change: -7 B (0%) Total Size: 1.2 MB
ℹ️ View Unchanged
|
|
thanks for the comment Jarda
I'm pretty sure we used this at some point. That said, it might have been in the very early stages. I think we can consider deprecating but we may want to check the list here to get a sense of third-party usage. https://wpdirectory.net/search/01EHKY2D587KZKKXJ2R1PDKVHZ |
youknowriad
approved these changes
Sep 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not sure why we normalize resolver functions to a
{ fulfill }object, so I did a bit of research and added a comment to the code.It seems to me that the
isFulfilledmethod, introduced in #6084, is not used anywhere in the Gutenberg code base and I'm not sure if it was ever used. These days, the selector/resolver state is stored in the store'smetadataand there is aifNotResolvedhelper incore-datathat uses a metadata selector. @youknowriad isisFulfilledindeed a candidate for deprecation, or is it still useful?The patch also refactors the code to remove destructuring that seems a bit too smart to me, and removes a stale JSDoc comment about the
queryparam that was added during some back-and-forth in #21289.