Lazy Import: Allow local paths as an option when importing #23751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
the
[Type] New API
|
Size Change: 0 B Total Size: 1.21 MB ℹ️ View Unchanged
|
gziolo
changed the title
|
This would be really useful. Do you think it might be possible for the usage to be more like how one might expect to use In other words, instead of... lazyImport( 'fbjs@^1.0.0', {
localPath: './lib/shallowEqual',
} );I would expect: lazyImport( 'fbjs/lib/shallowEqual@^1.0.0' );It might be slightly more challenging to implement, since it means we probably can't take advantage of the existing usage of |
|
It turns out that the usage of
If we would decide to reimplement it ourselves we would lose some of those options or we would have to find a common approach on how to deal with local paths. Now the question is whether we want to introduce a special case: lazyImport( 'fbjs/lib/shallowEqual@^1.0.0' );or we are fine with a more verbose API but also one that would work with all representations of |
gziolo
force-pushed
the
update/lazy-import-path
branch
from
8dbc73b
to
ebafd30
Compare
|
Error while building I think you need to add |
I think you run into the same strange issue with one of the dependencies from the benchmark, it should work on every subsequent install. I was able to reproduce it every time but it always worked for @aduth 🤷♂️ Upon investigation, it was always only one of the packages used in the benchmark. See: #22684 (comment) |
gziolo
force-pushed
the
update/lazy-import-path
branch
from
ebafd30
to
d64c2a9
Compare
mkaz
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A try to unblock #23712 where we want to add support for external templates installed from npm in
@wordpress/create-block.We miss a way to lazy import a local path from a package. It was only possible to import the script listed as
mainby the package.This PR adds a new option
localPaththat allows importing files other than those listed asmainfor the package.How has this been tested?
$ rm -rf node_modules $ npm install $ node packages/is-shallow-equal/benchmark/index.js`Should run all the benchmarks on the
@wordpress/is-shallow-equalpackage.Types of changes
New feature (non-breaking change which adds functionality).
Checklist: