ESLint Plugin: Update ESLint and related deps to 6.8.x #21424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gziolo
added
[Package] Scripts
gziolo
requested review from
ajitbohra,
dmsnell,
epiqueras,
nerrad,
noahtallen,
noisysocks,
ntwb and
youknowriad
as code owners
|
Size Change: 0 B Total Size: 890 kB ℹ️ View Unchanged
|
gziolo
force-pushed
the
update/eslint-6.8.x
branch
from
3e301f1
to
01edda8
Compare
gziolo
force-pushed
the
update/eslint-6.8.x
branch
from
01edda8
to
a51f2e3
Compare
aduth
requested changes
Apr 7, 2020
gziolo
force-pushed
the
update/eslint-6.8.x
branch
from
b69893b
to
a313759
Compare
aduth
approved these changes
Apr 8, 2020
|
|
||
| /* eslint-disable-next-line jest/expect-expect */ | ||
| it( 'captures logging in lifecycle', () => {} ); |
There was a problem hiding this comment.
What even is this testing? 🤔 Not technically in scope, but considering you might have some insight here, a code comment would be helpful (if it's not encompassed in the comment of beforeAll).
There was a problem hiding this comment.
Everything is explained in beforeAll and I added a reference as disable reason.
gziolo
force-pushed
the
update/eslint-6.8.x
branch
from
8f822ee
to
71b3bf3
Compare
Co-Authored-By: Andrew Duthie <andrew@andrewduthie.com>
gziolo
force-pushed
the
update/eslint-6.8.x
branch
from
71b3bf3
to
b0da90e
Compare
This was referenced May 5, 2020
Closed
This was referenced May 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings up to date all ESLint and its plugin packages used.
I had to disable
jest/expect-expectin the Gutenberg project because we have way too many tests that don't have assertions used. In a few places, I also had to disable some local usage where it conflicts with new additions to the ESLint rules introduced for Jest.@wordpress/eslint-plugineslint-plugin-jestdependency has been updated from requiring^22.15.1to requiring^23.8.2(#21424).eslint-plugin-jsdocdependency has been updated from requiring^21.0.0to requiring^22.1.0(#21424).eslint-plugin-react-hooksdependency has been updated from requiring^1.6.1to requiring^3.0.0(#21424).eslint-plugin-reactdependency has been updated from requiring^7.14.3to requiring^7.19.0(#21424).@wordpress/scriptseslintdependency has been updated from requiring^6.1.0to requiring^6.8.0(#21424).How has this been tested?
npm run lint-jsChecklist: