Upgrade react native to 0.62.2 #19950
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marecar3
changed the title
2 tasks
|
Size Change: 0 B Total Size: 1.14 MB ℹ️ View Unchanged
|
marecar3
added
the
Mobile App - i.e. Android or iOS
SergioEstevao
approved these changes
Apr 21, 2020
marecar3
commented
Apr 25, 2020
marecar3
requested review from
ajitbohra,
jorgefilipecosta,
youknowriad and
nerrad
as code owners
gziolo
reviewed
Apr 27, 2020
gziolo
reviewed
Apr 27, 2020
|
I appreciate all the work here. It doesn’t look like an easy task to make the lock file play right with web and mobile |
|
Feel free to leave an exact version of the packages because it looks like the lock file gets 10 000 lines updated 🙁 you can remove last 2 commits that fail on Travis. I can help later today |
Thanks @gziolo ! |
marecar3
force-pushed
the
rnmobile/update-rn-0-62
branch
from
3b4e850
to
1a0b17e
Compare
marecar3
requested review from
chrisvanpatten,
mkaz,
ntwb,
Soean,
talldan and
TimothyBJacobs
as code owners
# Conflicts: # package-lock.json
gziolo
reviewed
May 14, 2020
| @@ -65,6 +65,7 @@ const gpl2CompatibleLicenses = [ | |||
| '(MIT AND BSD-3-Clause)', | |||
| '(MIT AND Zlib)', | |||
| '(CC-BY-4.0 AND MIT)', | |||
| '0BSD', | |||
There was a problem hiding this comment.
0BSD is ISC without the requirement to maintain the copyright notice. It's about as close to public domain as you can get. While the FSF haven't commented on the compatibility of 0BSD, they have stated that ISC is GPL-compatible, which is enough for me.
pento
approved these changes
May 14, 2020
| @@ -65,6 +65,7 @@ const gpl2CompatibleLicenses = [ | |||
| '(MIT AND BSD-3-Clause)', | |||
| '(MIT AND Zlib)', | |||
| '(CC-BY-4.0 AND MIT)', | |||
| '0BSD', | |||
There was a problem hiding this comment.
0BSD is ISC without the requirement to maintain the copyright notice. It's about as close to public domain as you can get. While the FSF haven't commented on the compatibility of 0BSD, they have stated that ISC is GPL-compatible, which is enough for me.
# Conflicts: # package-lock.json
# Conflicts: # package-lock.json
2 tasks
# Conflicts: # package-lock.json # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json # packages/scripts/scripts/check-licenses.js
# Conflicts: # packages/react-native-editor/ios/Podfile.lock
# Conflicts: # packages/react-native-editor/ios/Podfile.lock # packages/react-native-editor/package.json
|
Closing in favor: Update RN to 0.63 PR #24872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related gutenberg-mobile PR: wordpress-mobile/gutenberg-mobile#2439
Checklist: