Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update npm-package-json-lint-config docs #19584

Merged
merged 1 commit into from Jan 12, 2020
Merged

Update npm-package-json-lint-config docs #19584

merged 1 commit into from Jan 12, 2020

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Jan 12, 2020

Description

Docs update follow up to #18160

Note: npmPackageJsonLintConfig prop in the package.json file needs to be renamed to npmpackagejsonlint.

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR. .

@ntwb ntwb added the [Package] npm-package-json-lint-config /packages/npm-package-json-lint-config label Jan 12, 2020
@ntwb ntwb requested a review from gziolo January 12, 2020 11:56
@ntwb ntwb self-assigned this Jan 12, 2020
gziolo
gziolo approved these changes Jan 12, 2020
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching 👍

@ntwb ntwb merged commit 0824b1e into master Jan 12, 2020
@ntwb ntwb deleted the update/npm-package-json-lint-config-docs branch January 12, 2020 23:11
@ellatrix ellatrix added this to the Gutenberg 7.3 milestone Jan 20, 2020
@naiba4 naiba4 mentioned this pull request Jan 4, 2024
Open
@MaxMood96 MaxMood96 mentioned this pull request Jan 4, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@nerrad nerrad Awaiting requested review from nerrad

Assignees

@ntwb ntwb

Labels
[Package] npm-package-json-lint-config /packages/npm-package-json-lint-config
Projects
None yet
Milestone
Gutenberg 7.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ntwb @gziolo @ellatrix