Scripts: Added temporary workaround for the default config used with lint-js command
#17744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`lint-js` command
gziolo
requested review from
ajitbohra,
nerrad,
ntwb and
youknowriad
as code owners
|
@youknowriad - can we include it in the next npm release, please? :) |
|
Sure 👍 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue: #17061.
This PR adds a temporary workaround for the default config used with
lint-jscommand. It uses linting rules for both e2e and unit tests with all files until override files globbing logic is fixed when usingeslintwith--config(related issue).Testing
I tested it with https://github.com/WordPress/gutenberg-examples. It's not that simple but this is what I did:
https://github.com/WordPress/gutenberg-examples/blob/fe9c5e5bd2657a8d1fff0eedef398c6f5a2dd1d9/test/examples.js#L1
node_modules/@wordpress/scripts/config/.eslintrc.js.npm run lint-jsto confirm it no longer reports errors.