Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templates list: info on whether a template has been customized should be accessible #42557

Closed
afercia opened this issue Jul 20, 2022 · 2 comments · Fixed by #48159
Closed

Templates list: info on whether a template has been customized should be accessible #42557

afercia opened this issue Jul 20, 2022 · 2 comments · Fixed by #48159
Assignees
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site

Comments

@afercia
Copy link
Contributor

afercia commented Jul 20, 2022

Description

Splitting this out from #42505

In the Templates list, the blue dot to indicate a template has been customized shows some info only on hover. There's no other indication available that informs keyboard users or assistive technology users a template has been customized.

There should be some text to provide this information in an accessible way.

I'd say the blue dot isn't very clear also for sighted users. It took some time to me to understand what it was about. And I had to hover the icon to get the related information. Visible text would benefit all users.

Also, this is a data table. I'd argue that the column cells should only contain the data type identified by the column header. The 'Added by' column should only contain info on who/what added the template. Instead, the text 'This template has been customized' is about the template state. It's a data that doesn't fit at all with 'Added by' and ideally should go in a separate column dedicated to the template state.

Step-by-step reproduction instructions

  • Make some changes to a default template and save.
  • Click Toggle navigation, then click Templates to open the Templates list.
  • Observe the 'Added by' column of the template you customized.
  • Observe the template icon shows a blue dot.
  • Hover the icon and observe a tooltip appears with text 'This template has been customized'.
  • Stop hovering the icon.
  • Observe the 'This template has been customized' text is not present in any other place on the page (not even in some hidden text in the source).
  • This important information is not available to keyboard users and screen reader users.

Screenshots, screen recording, code snippet

template customized

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site labels Jul 20, 2022
@afercia afercia self-assigned this Jul 20, 2022
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 21, 2022
@afercia
Copy link
Contributor Author

afercia commented Feb 13, 2023

@jameskoster @javierarce thanks for your feedback on #42505, #42555, #42589, and #47841.

To recapt:

It appears we all feel the templates/parts list needs improvements under various aspects that should be explored also under the light of future plans and new features of the templates list. For now, I suggest to focus on the specific problem of this issue: the information about the 'customized' state.

This:

Screenshot 2023-02-13 at 15 08 01

ins't that great, as the information is only visual and the tooltip appears only on hover. It's not accessible.

Also, when the list of templates/parts is very long, it's very hard to immediately identify the customized templates/parts:

Screenshot 2023-02-13 at 12 04 28

It's a relatively simple issue and it's waiting for a solution since more than 6 months. I'd like to suggest the simplest option: just add a second line in the 'Added by' cell with text: "User customized", as suggested in #42589 (comment)

@jameskoster
Copy link
Contributor

jameskoster commented Feb 13, 2023

I agree, it would be good to implement a light-weight solution that solves the issue now, and doesn't paint us into a corner with regards to future enhancements.

The suggestion can work, and we might even consider removing the blue dot. With the accompanying text it's not really that useful:

Screenshot 2023-02-13 at 16 15 52

The associated user is also removed. I'm not sure how useful that information is.

Also, when the list of templates/parts is very long, it's very hard to immediately identify the customized templates/parts:

Imo this part would be best served by filtering. Indeed we can use filtering to address a number of similar flows that are currently quite painful e.g:

  • View all templates added by a specific theme or plugin
  • View all the 'blog' templates
  • View templates created by a specific author

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Edit Site /packages/edit-site
Projects
None yet
3 participants