Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation block: placeholder menu border doesn't adjust to the menu's width #37077

Closed
priethor opened this issue Dec 2, 2021 · 2 comments · Fixed by #37089
Closed

Navigation block: placeholder menu border doesn't adjust to the menu's width #37077

priethor opened this issue Dec 2, 2021 · 2 comments · Fixed by #37089
Assignees
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@priethor
Copy link
Contributor

priethor commented Dec 2, 2021

Description

In Gutenberg 12.0.1 or WordPress 5.9 Beta 1, the border of the placeholder menu of the Navigation block doesn't adjust to its width.

Step-by-step reproduction instructions

  1. Spin up a WordPress 5.9 Beat, TT2, with or without the Gutenberg plugin.
  2. Go to Appearance->Editor
  3. Select the Navigation block
  4. The bounding box of the Navigation block's placeholder menu is narrower than the menu itself.

Screenshots, screen recording, code snippet

Grabacion.de.pantalla.2021-12-02.a.las.21.00.06.mov

Environment info

  • WordPress 5.9 Beta 1, with or without Gutenberg 12.0.1
  • Chrome, Firefox

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@priethor priethor added [Type] Bug An existing feature does not function as intended [Block] Navigation Affects the Navigation Block labels Dec 2, 2021
@priethor priethor added this to 📥 To do in Navigation block via automation Dec 2, 2021
@jasmussen
Copy link
Contributor

jasmussen commented Dec 3, 2021

Thanks for the ticket. I think this will be mitigated by a trio of PRs:

I will take a stab at a 4th one to see if I can reduce the placeholder state further, but it would be nice to get a green check for the three above as they all build upon each other.

Notably the last of those, removing the gray blob fake placeholder state, has a few dimensions to it:

  • It's not meant to be a loading state, it's meant to pass the "squint" test and indicate what the block is about. But in testing (outreach program) it keeps coming back that people think of it as a loading state and assume no further action is meant to be taken.
  • By removing the loading state and going back to a more basic placeholder, it might make it clear that themes are better off inserting a preconfigured navigation block, either with the Page List inserted from the start (I think TwentyTwentyTwo is already doing this), or even just loading by default the default navigation structure (as mused about in Introduce "Browser" and surface main navigation UI #36667).

In either case, to me it seems valuable to revert back to the navigation block looking unconfigured, when it is unconfigured. What do you think?

@priethor
Copy link
Contributor Author

priethor commented Dec 3, 2021

In either case, to me it seems valuable to revert back to the navigation block looking unconfigured, when it is unconfigured. What do you think?

I left a comment on #36858 to focus the conversation there 👍

Navigation block automation moved this from 📥 To do to ✅ Done Dec 28, 2021
@priethor priethor changed the title Navigation block: placeholder menu border doesn't adjut to the menu's width Navigation block: placeholder menu border doesn't adjust to the menu's width Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Development

Successfully merging a pull request may close this issue.

2 participants