Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colorise template parts and reusable blocks in the UI #32163

Closed
Tracked by #41241
jameskoster opened this issue May 24, 2021 · 12 comments · Fixed by #45473
Closed
Tracked by #41241

Colorise template parts and reusable blocks in the UI #32163

jameskoster opened this issue May 24, 2021 · 12 comments · Fixed by #45473
Assignees
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs User Documentation Needs new user documentation [Status] In Progress Tracking issues with work in progress

Comments

@jameskoster
Copy link
Contributor

jameskoster commented May 24, 2021

Other platforms successfully use colorisation to distinguish local / global entities within a document. We might explore doing the same for template parts and reusable blocks.

There's some backscroll in issue #26599 for context. That issue was closed as it touched on many other related (and now resolved) template-part-related concepts.

Colorisation considerations

  • List view (resting, hover, and active states)
  • Canvas (outlines / overlays in select mode and the Site Editor, Block Toolbar)
  • Inspector (icon in the Block description)
  • Inserter (block icon)

Screenshot 2021-05-24 at 15 56 45

Purple could be a good option, but might clash a bit with the "Ectoplasm" color scheme. Speaking of which, this color(s) should probably be static and not change with the specified color scheme.

I've seen green suggested for Reusable Blocks in other issues.

Figma file here to explore :)

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) [Feature] Full Site Editing [Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels May 24, 2021
@jasmussen
Copy link
Contributor

As an additional affordance to identifying block types, I think this can make a lot of sense. I don't think we should add too many new colors, though... 3 seems like a maximum. I look forward to fine tuning those colors to perfection as well 👌

@jasmussen
Copy link
Contributor

Oh and don't think I didn't see that rainbow emoji as a Figma label 🌈

@jameskoster

This comment was marked as outdated.

@jameskoster

This comment was marked as outdated.

@samxmunoz
Copy link

I'd still really love to see this - it's so confusing not having any sort of color-coding, bolding, or other visual queue for reusable blocks (aside from the icon that is the same color as everything else).

Even just making the reusable blocks icon stand out a little more in list view (highlighting would be amazing) would be helpful.

Without knowing it clients are going to make changes on their sites and not realize it impacts everything, or multiple contributors to a website are going to accidentally make a change globally.

Thank you!

@annezazu
Copy link
Contributor

annezazu commented Oct 19, 2022

After running a few different tests around the newer zoomed out view #41156, I wanted to note that colorization of template parts, patterns, etc will be advantageous in that view as well. Here's feedback from a coworker for example that helps underscore the benefit:

I think there might be value in thinking about how different “sections” are colored or represented. For example, maybe a pattern is a different color from a template part to distinguish which sections are going to be consistent across other templates and which are unique to the template you are presently editing. This might also help with conceptualizing the differences and how they interact with the design of your site.

As we think about this issue itself, I'd love for it to be thought of in the context of this new view too!

@annezazu
Copy link
Contributor

@jameskoster would you list this as Needs Dev or Needs Design feedback right now? Want to ensure everything on the phase 2 issue has either label where possible.

@jameskoster
Copy link
Contributor Author

Good question. I would say both :)

We need to settle on the final colors (cc @pablohoneyhoney), and precisely which elements get colorised, but these are things we can work out in the PR.

Making anything that is var(--wp-admin-theme-color) (outlines, overlays, active state in list view, etc) a different color would be a good start.

@jameskoster jameskoster added the Needs Dev Ready for, and needs developer efforts label Oct 20, 2022
@carolinan
Copy link
Contributor

I am curios about how a template part could be colored, if the blocks that fill it also have a background, or even if there is a body background that is not white.

@jameskoster
Copy link
Contributor Author

This issue is about how the UI can better indicate when you're working with template parts rather than styling them for the frontend.

@glendaviesnz glendaviesnz self-assigned this Nov 1, 2022
@glendaviesnz
Copy link
Contributor

Going to take a look at how this can be implemented today.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 2, 2022
@glendaviesnz
Copy link
Contributor

Initial PR for this here

@glendaviesnz glendaviesnz removed the Needs Dev Ready for, and needs developer efforts label Nov 2, 2022
@bph bph added the Needs User Documentation Needs new user documentation label Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Template Part Affects the Template Parts Block [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Synced Patterns Related to synced patterns (formerly reusable blocks) Needs User Documentation Needs new user documentation [Status] In Progress Tracking issues with work in progress
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

8 participants