Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent active states across the editor UI #41643

Open
richtabor opened this issue Jun 9, 2022 · 2 comments
Open

Inconsistent active states across the editor UI #41643

richtabor opened this issue Jun 9, 2022 · 2 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@richtabor
Copy link
Member

What problem does this address?

Was reviewing the current UI and noticed a few inconsistencies across active states for controls. We have three standard states for indicating an active state, two shades of black and the admin primary color.

Audit:

Uses #2f2f2f/ ($gray-800):

CleanShot 2022-06-09 at 13 39 59@2x

Uses #1e1e1e/ ($gray-900):

CleanShot 2022-06-09 at 13 38 29@2x

CleanShot 2022-06-09 at 13 39 12@2x

CleanShot 2022-06-09 at 13 42 05@2x

Uses var(--wp-admin-theme-color):

CleanShot 2022-06-09 at 13 40 32@2x

CleanShot 2022-06-09 at 13 46 33@2x

What is your proposed solution?

I propose we choose one of the shades of black (either #2f2f2f ($gray-800) or #1e1e1e ($gray-900)). Then employ that color consistently across all active states (including where we're currently using the primary admin color for the link/unlink UI).

@richtabor richtabor added the Needs Design Feedback Needs general design feedback. label Jun 9, 2022
@jameskoster
Copy link
Contributor

jameskoster commented Jun 10, 2022

Agreed, with perhaps the exception of List View. There the theme color creates a visual link with the canvas that can be helpful, especially when we get around to #32163.

Should we also consider toggles, checkboxes, radios? Maybe tokenfields too?

Screenshot 2022-06-10 at 10 27 59

Screenshot 2022-06-10 at 10 28 06

Screenshot 2022-06-10 at 10 28 35

Edit:

A couple of other considerations in the datepicker:

Screenshot 2022-06-10 at 10 37 11

@richtabor
Copy link
Member Author

Agreed, with perhaps the exception of List View. There the theme color creates a visual link with the canvas that can be helpful, especially when we get around to #32163.

That's the one I'm hesitant on most as well.

@jordesign jordesign added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. labels Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants