Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Comment Link Block #30577

Closed
jameskoster opened this issue Apr 7, 2021 · 3 comments · Fixed by #35965
Closed

Edit Comment Link Block #30577

jameskoster opened this issue Apr 7, 2021 · 3 comments · Fixed by #35965
Assignees
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress

Comments

@jameskoster
Copy link
Contributor

Here is an initial take on the design for the Edit Comment Link block. This block should only be available in the Site Editor, and potentially only when editing certain templates (Index, Single, Singular, Page).

edit-comment-link

Design feedback is politely requested for all aspects:

  • Icon
  • Toolbar actions
  • Inspector settings
  • Name
  • Description

Figma link here.

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 7, 2021
@jameskoster jameskoster added [Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Apr 7, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 9, 2021
@SantosGuillamot
Copy link
Contributor

Hello! 👋 I would like to wrap up all the issues related to the Post Comments block to start working on a Comment Loop block as explained in this tracking issue. I'd like to make a quick summary to ensure we are aligned on this one:

Description

Displays a link to edit the comment in the WordPress Dashboard. This link is only visible to Administrators and Editors.

Potential Settings

  • Typography: It should be the same as the Paragraph block.
  • Color Settings: It should be the same as the Paragraph block.
  • Link Settings: Open link in a new tab.

Of course, any feedback is welcome 🙂

@SantosGuillamot SantosGuillamot added this to To do in Comments Loop block via automation Sep 21, 2021
@SantosGuillamot SantosGuillamot added [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop New Block Suggestion for a new block and removed [Status] In Progress Tracking issues with work in progress Needs Design Feedback Needs general design feedback. labels Sep 21, 2021
@jameskoster
Copy link
Contributor Author

It's a shame the edit link will have to take folks to the existing comment management screens in wp-admin. In the future it would be nice to send them to an instance of the block editor where they can edit the comment visually.

@cbravobernal
Copy link
Contributor

@SantosGuillamot may I take this one? Thanks!

@SantosGuillamot SantosGuillamot added the [Status] In Progress Tracking issues with work in progress label Oct 19, 2021
@SantosGuillamot SantosGuillamot moved this from To do to In progress in Comments Loop block Oct 19, 2021
@gziolo gziolo moved this from In progress to In review in Comments Loop block Oct 27, 2021
Comments Loop block automation moved this from In review to Done Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress
Projects
No open projects
3 participants