Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment Reply Link Block #30576

Closed
jameskoster opened this issue Apr 7, 2021 · 2 comments · Fixed by #35774
Closed

Comment Reply Link Block #30576

jameskoster opened this issue Apr 7, 2021 · 2 comments · Fixed by #35774
Assignees
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress

Comments

@jameskoster
Copy link
Contributor

Here is an initial take on the design for the Comment Reply Link block. This block should only be available in the Site Editor, and potentially only when editing certain templates (Index, Single, Singular, Page).

comment-reply-link

Design feedback is politely requested for all aspects:

  • Icon
  • Toolbar actions
  • Inspector settings
  • Name
  • Description

Figma link here.

@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 7, 2021
@SantosGuillamot
Copy link
Contributor

Hello! 👋 I would like to wrap up all the issues related to the Post Comments block to start working on a Comment Loop block as explained in this tracking issue. I'd like to make a quick summary to ensure we are aligned on this one:

Description

Displays a link to reply to a comment.

Potential Settings

As pointed in this tracking issue, I think we can start creating a first version with just a link to the already working Post Comments Form block, and implement the inline form in the future.

Requirements

  • There is a Discussion Setting to select how many levels deep users want to allow for nested comments. We should take into account this and not show the Reply button if the limit is reached.
  • There is a Discussion Setting to set that users must be registered and logged in to comment. It would be nice to change the text if the setting is enabled and the user isn't logged. Something like this:

Screen Shot 2021-09-21 at 10 30 31

  • There is another global setting to allow new comments in posts. This can also be overwritten per post. We have to take this into account and not show the reply button if this is disabled.

Of course, any feedback is welcome 🙂

@SantosGuillamot SantosGuillamot added this to To do in Comments Loop block via automation Sep 21, 2021
@SantosGuillamot SantosGuillamot added [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Full Site Editing New Block Suggestion for a new block and removed Needs Design Feedback Needs general design feedback. labels Sep 21, 2021
@DAreRodz
Copy link
Contributor

Hey, @SantosGuillamot, I'm working on this issue, could you assign it to me while I create a PR? Thanks! 😁

@SantosGuillamot SantosGuillamot added the [Status] In Progress Tracking issues with work in progress label Oct 19, 2021
@SantosGuillamot SantosGuillamot moved this from To do to In progress in Comments Loop block Oct 19, 2021
@gziolo gziolo moved this from In progress to In review in Comments Loop block Oct 26, 2021
Comments Loop block automation moved this from In review to Done Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants