Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment Author Block #30572

Closed
jameskoster opened this issue Apr 7, 2021 · 5 comments · Fixed by #35595
Closed

Comment Author Block #30572

jameskoster opened this issue Apr 7, 2021 · 5 comments · Fixed by #35595
Assignees
@cbravobernal
Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress
Projects
Comments Loop block

Comments

@jameskoster
Copy link
Contributor

Here is an initial take on the design for the Comment Author block. This block should only be available in the Site Editor, and potentially only when editing certain templates (Index, Single, Singular, Page).

comment-author

Design feedback is politely requested for all aspects:

  • Icon
  • Placeholder when there is no context present
  • Toolbar actions
  • Inspector settings
  • Name
  • Description

Figma link here.
@jameskoster jameskoster added Needs Design Feedback Needs general design feedback. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Apr 7, 2021
@jameskoster jameskoster mentioned this issue Apr 7, 2021
Closed
9 tasks
@jameskoster jameskoster added [Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. labels Apr 7, 2021
@paaljoachim
Copy link
Contributor

Hey James

It looks like a good first iteration!
I think we can bring it over to "Needs dev" label.

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Apr 21, 2021
@carolinan
Copy link
Contributor

A basic version of this block as "Post Comment Author" was added in #24824

@carolinan carolinan added the [Block] Comments Affects the Comments Block - formerly known as Comments Query Loop label May 7, 2021
This was referenced Sep 21, 2021
Closed
Closed
@SantosGuillamot
Copy link
Contributor

Hello! 👋 I would like to wrap up all the issues related to the Post Comments block to start working on a Comment Loop block as explained in this tracking issue. I'd like to make a quick summary to ensure we are aligned on this one:

Description

Add the author of the specific comment.

Potential Settings

  • Typography: It should be the same as the Paragraph block.
  • Color Settings: It should be the same as the Paragraph block.
  • Link Settings:
    • Link to Authors URL: Clicking the name will take the user to that URL.
    • Open Author URL in a new tab.

References

Of course, any feedback is welcome 🙂

@SantosGuillamot SantosGuillamot added this to To do in Comments Loop block via automation Sep 21, 2021
@SantosGuillamot SantosGuillamot added New Block Suggestion for a new block and removed Needs Dev Ready for, and needs developer efforts labels Sep 21, 2021
@cbravobernal
Copy link
Contributor

May I take this one @SantosGuillamot?
Thanks!

@SantosGuillamot
Copy link
Contributor

May I take this one @SantosGuillamot?

Sure! I've just assigned you the issue 🙂

@SantosGuillamot SantosGuillamot moved this from To do to In progress in Comments Loop block Oct 13, 2021
@cbravobernal cbravobernal mentioned this issue Oct 13, 2021
Merged
7 tasks
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 13, 2021
@gziolo gziolo moved this from In progress to In review in Comments Loop block Oct 19, 2021
Comments Loop block automation moved this from In review to Done Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cbravobernal cbravobernal

Labels
[Block] Comments Affects the Comments Block - formerly known as Comments Query Loop [Feature] Blocks Overall functionality of blocks [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. New Block Suggestion for a new block [Status] In Progress Tracking issues with work in progress
Projects
No open projects
Comments Loop block
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Block: Post comment author]: Add link settings and block supports cbravobernal/gutenberg
5 participants
@jameskoster @paaljoachim @carolinan @SantosGuillamot @cbravobernal