useNestedSettingsUpdate: prevent unneeded syncing of falsy templateLo…

…ck values
WordPress · Dec 7, 2022 · edefaac · edefaac
1 parent d5dcbd1
commit edefaac
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/packages/block-editor/src/components/inner-blocks/use-nested-settings-update.js b/packages/block-editor/src/components/inner-blocks/use-nested-settings-update.js
@@ -52,13 +52,16 @@ export default function useNestedSettingsUpdate(
 
 	const { blockListSettings, parentLock } = useSelect(
 		( select ) => {
-			const rootClientId =
-				select( blockEditorStore ).getBlockRootClientId( clientId );
+			const {
+				getBlockRootClientId,
+				getBlockListSettings,
+				getTemplateLock,
+			} = select( blockEditorStore );
+
+			const rootClientId = getBlockRootClientId( clientId );
 			return {
-				blockListSettings:
-					select( blockEditorStore ).getBlockListSettings( clientId ),
-				parentLock:
-					select( blockEditorStore ).getTemplateLock( rootClientId ),
+				blockListSettings: getBlockListSettings( clientId ),
+				parentLock: getTemplateLock( rootClientId ) ?? false,
 			};
 		},
 		[ clientId ]