Reverting back to Space key since we've added a keyboard event for Sp…

…ace. Reinstate tabIndex
WordPress · Nov 17, 2021 · 48e288c · 48e288c
1 parent 4099726
commit 48e288c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/packages/block-editor/src/components/list-view/block-select-button.js b/packages/block-editor/src/components/list-view/block-select-button.js
@@ -31,6 +31,7 @@ function ListViewBlockSelectButton(
 		position,
 		siblingBlockCount,
 		level,
+		tabIndex,
 		onFocus,
 		onDragStart,
 		onDragEnd,
@@ -74,7 +75,7 @@ function ListViewBlockSelectButton(
 				onKeyDown={ onKeyDownHandler }
 				aria-describedby={ descriptionId }
 				ref={ ref }
-				tabIndex="0"
+				tabIndex={ tabIndex }
 				onFocus={ onFocus }
 				onDragStart={ onDragStartHandler }
 				onDragEnd={ onDragEnd }

diff --git a/packages/e2e-tests/specs/editor/various/block-hierarchy-navigation.test.js b/packages/e2e-tests/specs/editor/various/block-hierarchy-navigation.test.js
@@ -155,7 +155,7 @@ describe( 'Navigating the block hierarchy', () => {
 		// Return to first block.
 		await openListViewSidebar();
 		await page.keyboard.press( 'ArrowUp' );
-		await page.keyboard.press( 'Enter' );
+		await page.keyboard.press( 'Space' );
 
 		// Replace its content.
 		await pressKeyWithModifier( 'primary', 'a' );