Popover: lock the __experimentalPopoverPositionToPlacement function (#…

…47505)

* Rename and stabilize __experimentalPopoverPositionToPlacement

* Rename internal tests import statement

* Revert "Rename internal tests import statement"

This reverts commit 4a0602c.

* Revert "Rename and stabilize __experimentalPopoverPositionToPlacement"

This reverts commit 0d0a7aa.

* Use lock/unlock APIs to lock the `positionToPlacement` function

* Update CHANGELOG

* Add __experimental prefix

* Update CHANGELOG

packages/block-editor/src/components/url-popover/index.js

@@ -6,7 +6,7 @@ import { useState } from '@wordpress/element';
 import {
 	Button,
 	Popover,
-	__experimentalPopoverPositionToPlacement as positionToPlacement,
+	experiments as componentsExperiments,
 } from '@wordpress/components';
 import { chevronDown } from '@wordpress/icons';
 import deprecated from '@wordpress/deprecated';
@@ -16,6 +16,11 @@ import deprecated from '@wordpress/deprecated';
  */
 import LinkViewer from './link-viewer';
 import LinkEditor from './link-editor';
+import { unlock } from '../../lock-unlock';
+
+const { __experimentalPopoverLegacyPositionToPlacement } = unlock(
+	componentsExperiments
+);
 
 const DEFAULT_PLACEMENT = 'bottom';
 
@@ -46,7 +51,8 @@ function URLPopover( {
 	if ( placement !== undefined ) {
 		computedPlacement = placement;
 	} else if ( position !== undefined ) {
-		computedPlacement = positionToPlacement( position );
+		computedPlacement =
+			__experimentalPopoverLegacyPositionToPlacement( position );
 	}
 	computedPlacement = computedPlacement || DEFAULT_PLACEMENT;
 

packages/components/CHANGELOG.md

@@ -16,6 +16,8 @@
 -   `NavigatorButton`: Reuse `Button` types ([47754](https://github.com/WordPress/gutenberg/pull/47754)).
 -   `ToolsPanel`: Allow display of optional items when values are updated externally to item controls ([47727](https://github.com/WordPress/gutenberg/pull/47727)).
 -   `ToolsPanel`: Ensure display of optional items when values are updated externally and multiple blocks selected ([47864](https://github.com/WordPress/gutenberg/pull/47864)).
+-   `CustomSelectControl`: lock the `__experimentalShowSelectedHint` prop ([#47229](https://github.com/WordPress/gutenberg/pull/47229)).
+-   Lock the `__experimentalPopoverPositionToPlacement` function and rename it to `__experimentalPopoverLegacyPositionToPlacement` ([#47505](https://github.com/WordPress/gutenberg/pull/47505)).
 
 ## 23.3.0 (2023-02-01)
 

packages/components/src/index.js

@@ -126,7 +126,6 @@ export { default as PanelHeader } from './panel/header';
 export { default as PanelRow } from './panel/row';
 export { default as Placeholder } from './placeholder';
 export { default as Popover } from './popover';
-export { positionToPlacement as __experimentalPopoverPositionToPlacement } from './popover/utils';
 export { default as QueryControls } from './query-controls';
 export { default as __experimentalRadio } from './radio-group/radio';
 export { default as __experimentalRadioGroup } from './radio-group';

packages/components/src/private-apis.js

@@ -7,6 +7,7 @@ import { __dangerousOptInToUnstableAPIsOnlyForCoreModules } from '@wordpress/pri
  * Internal dependencies
  */
 import { default as CustomSelectControl } from './custom-select-control';
+import { positionToPlacement as __experimentalPopoverLegacyPositionToPlacement } from './popover/utils';
 
 export const { lock, unlock } =
 	__dangerousOptInToUnstableAPIsOnlyForCoreModules(
@@ -17,4 +18,5 @@ export const { lock, unlock } =
 export const experiments = {};
 lock( experiments, {
 	CustomSelectControl,
+	__experimentalPopoverLegacyPositionToPlacement,
 } );