Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/metadata saving #629

Closed
wants to merge 4 commits into from
Closed

Fix/metadata saving #629

wants to merge 4 commits into from

Conversation

pbking
Copy link
Contributor

@pbking pbking commented May 10, 2024

Fixes the following issues:

  • Retain copyright text in style.css when updating metadata
  • Uses only major/minor version of wordpress for "tested up to" value
  • Use existing license in style.css instead of overwriting.
  • Use existing Requires WP in style.css instead of overwriting.

Fixes #523

To test:

Click "Update" on the Metadata modal of CBT.

Note that the "Tested Up to" value is only major.minor
Note that the license values remain unchanged (set it to something noticeable before saving to ensure this is true)
Note that the Requires WP in style css remains unchanged (set it to something noticeable before saving to ensure this is true)
Note that the license text remains after saving.

@pbking pbking changed the title Fix/meatadata saving Fix/metadata saving May 13, 2024
@pbking
Copy link
Contributor Author

pbking commented May 14, 2024

Closing in deference to #634 and #635

@pbking pbking closed this May 14, 2024
@vcanales vcanales deleted the fix/meatadata-saving branch May 23, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure patch version gets removed when theme is exported
1 participant