Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prefix to the names in the PHP global namespace. #628

Merged
merged 23 commits into from
May 14, 2024
Merged

Add prefix to the names in the PHP global namespace. #628

merged 23 commits into from
May 14, 2024

Conversation

matiasbenedetto
Copy link
Contributor

@matiasbenedetto matiasbenedetto commented May 10, 2024 •
edited

What?

Add prefixes to the names in the PHP global namespace.

Why?

Fixes: #627

@matiasbenedetto matiasbenedetto added the enhancement New feature or request label May 10, 2024
@matiasbenedetto matiasbenedetto marked this pull request as draft May 10, 2024 15:23
@matiasbenedetto
Rename Form_Messages to CBT_Form_Messages
b7a7bac
@matiasbenedetto
Rename Theme_Create to CBT_Theme_Create
2ad8444
@matiasbenedetto
Rename Theme_Fonts to CBT_Theme_Fonts
fe8c69a
@matiasbenedetto
Rename Theme_Form to CBT_Theme_Form
c7412da
@matiasbenedetto
Rename Theme_Json to CBT_Theme_JSON
cabcbf4
@matiasbenedetto
Rename Theme_Media to CBT_Theme_Media
7c05039
@matiasbenedetto
Rename Theme_Patterns to CBT_Theme_Patterns
ec936ca
@matiasbenedetto
Rename Theme_Readme to CBT_Theme_Readme
9312544
@matiasbenedetto
Rename Theme_Styles to CBT_Theme_Styles
5fcce82
@matiasbenedetto
Rename Theme_Tags to CBT_Theme_Tags
fe683f2
@matiasbenedetto
Rename Theme_Templates to CBT_Theme_Templates
dbf83a7
@matiasbenedetto
Rename Theme_Utils to CBT_Theme_Utils
4bc1cab
@matiasbenedetto
Rename Theme_Zip to CBT_Theme_Zip
c253852
@matiasbenedetto
rename augment_resolver_with_utilities to cbt_augment_resolver_with_u…
f6314b4 
…tilities
@matiasbenedetto
rename MY_Theme_JSON_Resolver to CBT_MY_Theme_JSON_Resolver
0020cf4
@matiasbenedetto
Rename run_create_block_theme to cbt_run_create_block_theme
9eb7867
@matiasbenedetto
Rename Create_Block_Theme_Admin to CBT_WP_Admin
7328105
@matiasbenedetto
Rename Create_Block_Theme_API to CBT_Theme_API
0892025
@matiasbenedetto
Rename Create_Block_Theme_Loader to CBT_Plugin_Loader
659a48e
@matiasbenedetto
Rename Create_Block_Theme class to CBT_Plugin
dd65f6b
@matiasbenedetto matiasbenedetto marked this pull request as ready for review May 10, 2024 16:18
vcanales
vcanales approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@vcanales vcanales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We might want to merge soon, since this impacts most of the codebase, the longer we wait, it'll get harder and harder to resolve conflicts.

@pbking
Copy link
Contributor

pbking commented May 14, 2024

I brought trunk in and refactored the readme file changes. Looks fine now.

I agree that this should be brought in sooner than later.

@pbking pbking merged commit 424ebee into trunk May 14, 2024
2 checks passed
@pbking pbking deleted the add/class-prefix branch May 14, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcanales vcanales vcanales approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Create Block Theme Release Planning
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Names in the global namespace should be prefixed
3 participants
@matiasbenedetto @pbking @vcanales