Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure patch version gets removed when theme is exported #523

Closed
iamtakashi opened this issue Mar 19, 2024 · 3 comments · Fixed by #635
Closed

Make sure patch version gets removed when theme is exported #523

iamtakashi opened this issue Mar 19, 2024 · 3 comments · Fixed by #635
Labels
bug Something isn't working

Comments

@iamtakashi
Copy link

RECOMMENDED: Tested up to is recommended to have major versions only (e.g. 5.8). Patch version is not needed (e.g. 5.8.1).

When I run the theme check, this often comes up. Let's make sure it gets removed when the theme is exported. It seems to be low-hanging fruit that will save us time!

@iamtakashi iamtakashi changed the title Make sure patch version get removed when theme is exported. Make sure patch version gets removed when theme is exported Mar 19, 2024
@mikachan mikachan added the bug Something isn't working label Apr 12, 2024
@pbking
Copy link
Contributor

pbking commented May 9, 2024

I don't believe that we should be automatically removing the patch version. It's recommended, though not enforced and the Automattic theme workflow still depends on patch versioning.

The Metadata editor allows for the version to be changed. It's not automated, but you can remove the patch version in that way.

I do believe that the patch version can be excluded when creating/cloning a theme though.

@mikachan
Copy link
Member

I believe this issue is in reference to the "Tested up to" WordPress version number, not the theme version number.

@pbking
Copy link
Contributor

pbking commented May 10, 2024

Ahhh

Silly. Of course.

In that case, yrs of course!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
3 participants