Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TT1-blocks: Update theme json #29

Draft
wants to merge 12 commits into
base: trunk
Choose a base branch
from
Draft

TT1-blocks: Update theme json #29

wants to merge 12 commits into from

Conversation

carolinan
Copy link
Collaborator

WIP

@@ -179,23 +144,7 @@ hr.is-style-twentytwentyone-separator-thick,
border-bottom-width: 3px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can remove this, can we?

.wp-block-separator.is-style-dots > hr {
display: none;
}

/* In Twenty Twenty-One, separators are 100% wide. This replicates that approach */
.wp-block-separator:not(.is-style-wide):not(.is-style-dots) {
width: 100%;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, it will alter people's websites

Copy link
Collaborator Author

@carolinan carolinan Jun 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Active Installations: 100+

I think breaking some backward compatibility is OK because the users still gain more features that did not exist when the theme was released....

.wp-block-latest-posts {
padding-left: 0;
}

.wp-block-latest-posts.is-style-twentytwentyone-latest-posts-dividers {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sucks cause the style variation doesn't even look like the original theme. Can we get rid of it altogether and just make it into a block pattern?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and it can always be adjusted in a later PR.

@MaggieCabrera
Copy link
Collaborator

I gave this a quick pass today, would love to hear your thoughts on most of the reminder of the CSS. I'm happy to keep minor things like the offset on text decoration or anti aliasing on the fonts, but I'd love to get rid of most of the block style stuff if at all possible but it would be disruptive. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants