singular page template scaffold #146
Conversation
version 1 basic scaffold (tested in editor)
|
Editors note: apologies its been a white since PR'ing to a project this big, im too used to smaller project use of Git. In reference to work on #142 from Theme session @ WCAsia
|
| @@ -0,0 +1,31 @@ | |||
| <!-- wp:template-part {"slug":"header","theme":"community-themes/poetry"} /--> | |||
There was a problem hiding this comment.
| <!-- wp:template-part {"slug":"header","theme":"community-themes/poetry"} /--> | |
| <!-- wp:template-part {"slug":"header","tagName":"header"} /--> |
We need the header tagName for accessibility, and we need to remove the theme slug because that route may not be the same for every installation
| <!-- /wp:group --></main> | ||
| <!-- /wp:group --> | ||
|
|
||
| <!-- wp:template-part {"slug":"footer","tagName":"footer","area":"footer"} /--> |
There was a problem hiding this comment.
| <!-- wp:template-part {"slug":"footer","tagName":"footer","area":"footer"} /--> | |
| <!-- wp:template-part {"slug":"footer","tagName":"footer"} /--> |
We don't need to define the area because it's already defined in theme.json (or should be!)
| <!-- /wp:separator --> | ||
|
|
||
|
|
||
| <!-- wp:pattern {"slug":"poetry/hidden-post-navigation"} /--></div> |
There was a problem hiding this comment.
This doesn't exist, we should create it! It's fine if we add it to this PR
There was a problem hiding this comment.
This is looking really solid. I added a few comments.
One more thing to keep in mind: by deciding to make this a singular template instead of single, we are using the same template for pages and posts, which means posts will not have a comments block. It could be a design decision for this theme, but it feels a little heavy-handed to me.
version 1 basic scaffold (tested in editor)