Extra: do not allow ambiguous conditions (needs PHPCS 3.9.0) #2429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new PHPCS 3.9.0 sniff will flag code which contains a `||` and a `&&` operator in the same condition and their precedence is not clarified via parenthesis. This should allow for users of WPCS to find/prevent some bugs in code. I'd personally would **_highly_** recommend for WP Core to also use this sniff, but I suspect that will need due discussion/Make post/handbook change. Note: running this sniff on WP Core as-is, would (to my surprise) not actually trigger any new errors. Includes updating a code snippet in the Ruleset test to comply.
jrfnl
added
Component: Extra
Type: Enhancement
Status: Review ready
Focus: Code analysis
dingo-d
approved these changes
Mar 4, 2024
GaryJones
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Composer: raise the minimum supported PHPCS version to 3.9.0
Extra: do not allow ambiguous conditions
This new PHPCS 3.9.0 sniff will flag code which contains a
||and a&&operator in the same condition and their precedence is not clarified via parenthesis.This should allow for users of WPCS to find/prevent some bugs in code.
I'd personally would highly recommend for WP Core to also use this sniff, but I suspect that will need due discussion/Make post/handbook change.
Note: running this sniff on WP Core as-is, would (to my surprise) not actually trigger any new errors.
Includes updating a code snippet in the Ruleset test to comply.