Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix - Lowercase custom sniff properties #2391

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Hotfix - Lowercase custom sniff properties #2391

wants to merge 15 commits into from

Commits on Sep 17, 2023

  1. Lowercase checks against the passed parameters to helper traits for c… 

    …ustom properties

Printing, escaping and sanitization trait helpers.
    @dingo-d
    dingo-d committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    557b43e View commit details
    Browse the repository at this point in the history

  2. Lowercase checks for the added custom propery in the DirectDBQuerySniff

    @dingo-d
    dingo-d committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    2952d93 View commit details
    Browse the repository at this point in the history

  3. Lowercase checks for the added custom propery in the NonceVerificatio… 

    …nSniff
    @dingo-d
    dingo-d committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    8e65466 View commit details
    Browse the repository at this point in the history

  4. Added tests that will check if the mixed-cased custom function name w… 

    …on't trigger errors if allowed
    @dingo-d
    dingo-d committed Sep 17, 2023
    Configuration menu
    Copy the full SHA
    03519cf View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2023

  1. Add a new parameter for lowecasing array keys and values when arrays … 

    …are merged
    @dingo-d
    dingo-d committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    d6ac1b5 View commit details
    Browse the repository at this point in the history

  2. Extract the lowercased content for the caching functions

    @dingo-d
    dingo-d committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    976c1c5 View commit details
    Browse the repository at this point in the history

  3. Update the code that uses merge array and needs to be lowercased

    @dingo-d
    dingo-d committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    4556d69 View commit details
    Browse the repository at this point in the history

  4. Move lowecasing functionality at the beginning of the helper 

    There are some early returns that would make lowecasing not happen even if we passed the last parameter as true.
    @dingo-d
    dingo-d committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    0cdebde View commit details
    Browse the repository at this point in the history

  5. Update tests

    @dingo-d
    dingo-d committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    af15790 View commit details
    Browse the repository at this point in the history

  6. Fix phpcs violation in the ruleset helper

    @dingo-d
    dingo-d committed Sep 18, 2023
    Configuration menu
    Copy the full SHA
    37389f8 View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. Apply PR suggestions in ruleset helper

    @dingo-d
    dingo-d committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    30c3e3d View commit details
    Browse the repository at this point in the history

  2. Revert the change of the array values lowercasing in the NoSilenceErr… 

    …ors sniff
    @dingo-d
    dingo-d committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    794f4cf View commit details
    Browse the repository at this point in the history

  3. Change the letter case of passed properties, not methods in tests

    @dingo-d
    dingo-d committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    d9b23ed View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2023

  1. Update WordPress/Helpers/RulesetPropertyHelper.php 

    Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
    @dingo-d @jrfnl
    dingo-d and jrfnl committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    93f7c6a View commit details
    Browse the repository at this point in the history

  2. Update WordPress/Helpers/RulesetPropertyHelper.php 

    Co-authored-by: Juliette <663378+jrfnl@users.noreply.github.com>
    @dingo-d @jrfnl
    dingo-d and jrfnl committed Sep 23, 2023
    Configuration menu
    Copy the full SHA
    b4c1765 View commit details
    Browse the repository at this point in the history