Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape output sniff fix for static method calls #2370

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Escape output sniff fix for static method calls #2370

wants to merge 15 commits into from

Commits on Sep 22, 2023

  1. Add additional tests for checking static method calls

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    a50ddd2 View commit details
    Browse the repository at this point in the history

  2. Add a case to identify unescaped static method calls in the sniff

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    39ef8e9 View commit details
    Browse the repository at this point in the history

  3. Update test cases to include FQCNs

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    a4b4624 View commit details
    Browse the repository at this point in the history

  4. Sniff update WIP 

    Need to write a recursive method that will check the fully qualified class names and if they have a static method call in them. We should also be careful not to catch the throw Exception cases, as for those we do want to check the parameters of the static method if they are escaped or not.
    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    0da61dd View commit details
    Browse the repository at this point in the history

  5. Add additional tests for checking fully qualified class names

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    2dd977c View commit details
    Browse the repository at this point in the history

  6. Update the sniff

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d48f71f View commit details
    Browse the repository at this point in the history

  7. Update tests 

    Add check for static public properties, enums and constants.
    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    9280466 View commit details
    Browse the repository at this point in the history

  8. Update sniff to catch extra cases and prevent fixer issues

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    18df81f View commit details
    Browse the repository at this point in the history

  9. Update docblocks

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    92492aa View commit details
    Browse the repository at this point in the history

  10. Minor docbloc update

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    f9f0bdc View commit details
    Browse the repository at this point in the history

  11. Update the escaping functions trait 

    Add a way to identify static methods in the is_escaping_function, used for setting the customEscapingFunctions.
    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    c4915b5 View commit details
    Browse the repository at this point in the history

  12. Update tests

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    e1c145e View commit details
    Browse the repository at this point in the history

  13. Add a check for escaping functions in the static methods

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    d02d85f View commit details
    Browse the repository at this point in the history

  14. Update the escaping functions trait 

    Split the merge function to merge lowercased method/function names, because PHP is case insensitive for all class, namespace and method names.
    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    21c5742 View commit details
    Browse the repository at this point in the history

  15. Update tests

    @dingo-d
    dingo-d committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    4a48492 View commit details
    Browse the repository at this point in the history