New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds documentation for WordPress.WP.CronInterval #1823
Adds documentation for WordPress.WP.CronInterval #1823
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @NielsdeBlaauw Lekker bezig!
Loved seeing those five PRs coming in.
Reviewed this one and - aside from some nitpicks - there are two points which need attention. Note: these points may well also apply to the other doc PRs you send in:
1. Complying with the coding standards for the examples
Aside from the issue being demonstrated, the code samples should comply with the WP Coding Standards.
That means that closures as callbacks for filter hooks are not allowed (as they can't be unhooked).
While the sniff should still detect these kind of issues, even in code which doesn't comply with the standards, the example code used in the documentation should be "clean".
2. Highlighting of the important bits
The particular bit in the code which is the actual "problem" should be wrapped in <em>
tags which will allow the code to be highlighted when the HTML/Markdown generators are used.
Ah yes, noticed the |
@NielsdeBlaauw Excellent! Thanks. The same goes for your earlier PR #1730, so if you have a chance to update that one too.... 😇 |
Haven't done a full review of any of them, but I did just have a quick look and left some small remarks here and there which might be helpful for when you are updating the PRs tomorrow anyway. |
Update WordPress/Docs/WP/CronIntervalStandard.xml Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com> Update WordPress/Docs/WP/CronIntervalStandard.xml Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com> Update WordPress/Docs/WP/CronIntervalStandard.xml Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com> Update WordPress/Docs/WP/CronIntervalStandard.xml Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com> Update WordPress/Docs/WP/CronIntervalStandard.xml Co-Authored-By: Juliette <663378+jrfnl@users.noreply.github.com> Seperates function definition
f15f1b8
to
86d7dbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for updating it!
Related to #1722