Skip to content

Commit

Permalink
GH Actions: minor tweaks
Browse files Browse the repository at this point in the history
* Remove `--checkstyle` for a lint job which doesn't display with `cs2pr`.
* Remove a stray condition.
  • Loading branch information
jrfnl committed Feb 16, 2024
1 parent eaa70fe commit 4559123
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/quicktest.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:
- name: Lint PHP files against parse errors
if: ${{ matrix.dependencies == 'stable' }}
run: composer lint -- --checkstyle
run: composer lint

- name: Run the unit tests without code coverage
if: ${{ github.ref_name != 'develop' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
custom-cache-suffix: $(date -u "+%Y-%m")

- name: "Composer: downgrade PHPCS dependencies for tests (lowest)"
if: ${{ ! startsWith( matrix.php, '8' ) && matrix.dependencies == 'lowest' }}
if: ${{ matrix.dependencies == 'lowest' }}
run: >
composer update --prefer-lowest --no-scripts --no-interaction
squizlabs/php_codesniffer
Expand Down

0 comments on commit 4559123

Please sign in to comment.