This repository has been archived by the owner on Sep 16, 2022. It is now read-only.
Enroll a single device #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rptrchv
reviewed
Jul 1, 2019
|
|
||
|
|
||
| WOTT_ENDPOINT = os.getenv('WOTT_ENDPOINT', 'https://api.wott.io') | ||
| PROJECT = 'wott-244904' |
rptrchv
reviewed
Jul 1, 2019
|
|
||
| WOTT_ENDPOINT = os.getenv('WOTT_ENDPOINT', 'https://api.wott.io') | ||
| PROJECT = 'wott-244904' | ||
| LOCATION = 'europe-west1' |
rptrchv
reviewed
Jul 1, 2019
| def create_client(): | ||
| # iot.DeviceManagerClient doesn't do this himself, unlike other Google libs. | ||
| if 'GOOGLE_APPLICATION_CREDENTIALS' in os.environ: | ||
| with open(os.environ['GOOGLE_APPLICATION_CREDENTIALS']) as key: |
rptrchv
reviewed
Jul 1, 2019
| return client | ||
|
|
||
|
|
||
| def create_registry(client, project_name, location, registry_name, pubsub_topic, ca_cert): |
There was a problem hiding this comment.
Pls fix PEP8 compliance of this function code
rptrchv
reviewed
Jul 1, 2019
| device = client.create_device(registry_path, device) | ||
| else: | ||
| print(f'Updating device {device_name}') | ||
| device = types.Device( |
There was a problem hiding this comment.
Why don't you use the device instance received in the try clause?
rptrchv
reviewed
Jul 1, 2019
|
|
||
|
|
||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
Pls carefully check all arguments' required and default values. Many of them look wrong
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WoTTsecurity/api#278
Note: the
--deviceargument is optional because if it's not specified this utility should list all devices and enroll all of them. To do this it needs an API key (WoTTsecurity/api#278), so it's not yet implemented.