Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for electron v21 prebuilds #909

Merged
merged 1 commit into from Nov 26, 2022

Conversation

m4heshd
Copy link
Contributor

@m4heshd m4heshd commented Nov 24, 2022

Electron v21 is the latest stable. Prebuilds are tested against module version 109.

@m4heshd m4heshd requested review from JoshuaWise and a team as code owners November 24, 2022 06:24
@x6pnda
Copy link

x6pnda commented Nov 25, 2022

Waiting for this build actually! Decided to use another package for our project because of lacking support for node module version 109

@m4heshd
Copy link
Contributor Author

m4heshd commented Nov 25, 2022

@x6pnda What's the alternative you went with?

@neoxpert
Copy link
Contributor

neoxpert commented Nov 25, 2022

The package is just working fine with Electron v21, if you rebuild the native module after install. Alternativly one could also build the module manually and drop the .node module in the respective lookup paths.

At least after two weeks of testing with Electron v21 we did not encounter any issues so far and there should not have been any breaking changes with the current API.

@m4heshd
Copy link
Contributor Author

m4heshd commented Nov 25, 2022

@neoxpert In my experience, like 70% of the users shy away from native libs if there aren't any prebuilt binaries for their preferred runtime. For some reason, people hate building native modules locally. 🤷🏽

Copy link
Member

@mceachen mceachen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mceachen mceachen merged commit b992d04 into WiseLibs:master Nov 26, 2022
@x6pnda
Copy link

x6pnda commented Nov 29, 2022

@neoxpert Sadly due to various security and machine limits, we are unable to rebuild native modules. That's why it's important to us to have modules support the latest node/electron versions and automatic detection so it downloads the correct version. This is more of a suggestion which can be added in a later stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants