Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use pkg-config crate to search for
xenstore.pc
and retrieve theLibrary
configuration in order to statically link libxenstore, when thestatic
feature has been specified.A couple of bugs and gotchas here
.statik()
doesn't have any effect because it's conditioned by the static library being outside of/usr/lib
. (see Static linking is too restrictive rust-lang/pkg-config-rs#102). On top of that, the author couldn't remember why this restriction was put in place, and there hasn't been any new release yet that would remove this codeLibrary
struct returned by pkg-config doesn't expose theRequired.private
field, which is necessary to specify that we need to link withxentoolcore
as well, sincexenstore
depends on it. So we need to specify this manually. It may break in the future if Xenstore adds or remove any of its dependencies unfortunately