WIP: error handling #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Wenzel
requested changes
Jul 5, 2019
|
|
||
| pub const PAGE_SHIFT: u32 = xenctrl_sys::XC_PAGE_SHIFT; |
There was a problem hiding this comment.
You need to export these constants as well
There was a problem hiding this comment.
Sorry, I forgot this. PR updated.
tathanhdinh
force-pushed
the
error_support_wip
branch
from
6d1cb29
to
1b00ae7
Compare
Wenzel
requested changes
Jul 6, 2019
src/lib.rs
Outdated
|
|
||
| pub fn new() -> Result<Self,Error> { | ||
| impl XenControl { | ||
| pub fn from( |
There was a problem hiding this comment.
Why did you replaced the new function, which is a convention to have an object constructor, by the name from ?
You break the API here, and i don't understand what this brings us ?
|
Sorry, I will change this. |
tathanhdinh
force-pushed
the
error_support_wip
branch
from
1b00ae7
to
c5add66
Compare
|
Merging this one ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR does:
XcXc naming #1