docs: Fetching translation from Weblate reworked #9275

comradekingu · 2023-05-19T12:19:54Z

Proposed changes

Checklist

Lint and unit tests pass locally with my changes.
I have added tests that prove my fix is effective or that my feature works.
I have added documentation to describe my feature.
I have squashed my commits into logic units.
I have described the changes in the commit messages.

Other information

comradekingu · 2023-05-19T12:21:18Z

docs/devel/integration.rst

-developing the code. You might want to introduce review of those strings using
+Monolingual formats need to be configured so that new strings are added to
+:ref:`component-template`. This is typically done by developers as they
+develop the code. You might want to introduce review of those strings using


Suggested change

develop the code. You might want to introduce review of those strings using

develop the code.

You might want to introduce review of those strings in Weblate using

?

comradekingu · 2023-05-19T12:22:11Z

docs/devel/integration.rst

-   should also cover :ref:`avoid-merge-conflicts`.
+   Integrate this into your contrinuous-integration pipelines
+   if you want new strings to appear automatically for translation.
+   Such a pipeline should also cover :ref:`avoid-merge-conflicts`.


Does this means the user is covered, or need to attend to it themselves?

comradekingu · 2023-05-19T12:22:58Z

docs/devel/integration.rst


-Weblate stores all translation the version control repository. It can be either
-connected to upstream one, or it can be only internal. The :guilabel:`Repository
-maintenance` lets you manipulate with the repository.


(This "manipulate with the repository" is very strange, so it might be my take is off.)

docs/devel/integration.rst

comradekingu · 2023-05-19T12:26:29Z

docs/devel/integration.rst

-translations. It does not however perform any automatic cleanup of stale
-strings as that might have unexpected outcomes. If you want to do this, please
-install :ref:`addon-weblate.cleanup.generic` add-on which will handle the
+strings not present in the :ref:`component-template`, or other translations.


(I don't understand "and not in actual translations" at all, so my take is likely off here.)

docs/devel/integration.rst

comradekingu · 2023-05-19T12:31:09Z

docs/devel/integration.rst

@@ -116,24 +118,24 @@ Introducing new strings
 +++++++++++++++++++++++

 You can add new strings in Weblate with :ref:`component-manage_units` turned


Does having it on allow adding strings (correct now), or does that add strings btw.?

"When it is on"? Is it off by default? Manually? Not a very strong sentence.

codecov · 2023-05-19T15:45:50Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.83%. Comparing base (16af367) to head (d3e47f6).
Report is 1906 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #9275   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         551      551           
  Lines       57019    57019           
  Branches     9076     9076           
=======================================
  Hits        51791    51791           
  Misses       3635     3635           
  Partials     1593     1593

github-actions · 2023-06-19T02:02:34Z

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.