New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Translating.rst reworked and line-shifted #7007

Open

comradekingu wants to merge 5 commits into WeblateOrg:main from comradekingu:patch-279

Contributor

comradekingu commented Dec 24, 2021 •

edited

Can I put #6169 (comment) here?


          Docs: Reworked Translating.rst reworked

7813c2b

comradekingu commented

View reviewed changes

docs/user/translating.rst Outdated

-              :guilabel:`Not translated strings` or :guilabel:`Strings needing action`. If the whole project
-              is translated, without error, :guilabel:`All strings` is still available.
+              :guilabel:`Not translated strings` or :guilabel:`Strings needing action`.
+              If the whole project is translated, without error, :guilabel:`All strings` is still available.

Contributor Author

comradekingu Dec 24, 2021

Suggested change

      
            If the whole project is translated, without error, :guilabel:`All strings` is still available.
          
            If the whole project is translated without any errors, :guilabel:`All strings` is still available.

This actually meant the label is always available when a project is translated, as opposed to some of the time.

comradekingu commented

View reviewed changes

docs/user/translating.rst Outdated

-              available to signed-in users, in cases where uncertainty about the translation
-              arises, prompting other translators to review it.
+              Anonymous users can only (by default) forward suggestions.
+              Doing so is still available to signed-in users, in cases where uncertainty

Contributor Author

comradekingu Dec 24, 2021

Suggested change

      
            Doing so is still available to signed-in users, in cases where uncertainty
          
            Doing so is still available for signed-in users, in cases where uncertainty


          More fixes

420dea5

nijel assigned comradekingu

Member

nijel commented Dec 24, 2021

Can I put #6169 (comment) here?

Please no, the bigger the pull request is, the harder it is to review.

codecov bot commented Dec 24, 2021 •

edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.79%. Comparing base (6aee586) to head (58f8177).
Report is 1838 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7007      +/-   ##
==========================================
- Coverage   90.82%   90.79%   -0.03%     
==========================================
  Files         554      559       +5     
  Lines       57306    57534     +228     
  Branches     9122     9180      +58     
==========================================
+ Hits        52046    52236     +190     
- Misses       3640     3670      +30     
- Partials     1620     1628       +8

see 52 files with indirect coverage changes

nijel assigned orangesunny and unassigned comradekingu

github-actions bot commented Feb 7, 2022

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

nijel removed the wontfix label


          Merge branch 'main' into patch-279

86d09cb

github-actions bot commented Mar 11, 2022

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

nijel removed the wontfix label

github-actions bot commented Apr 16, 2022

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

nijel added documentation and removed wontfix labels

github-actions bot commented May 21, 2022

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

orangesunny removed the wontfix label


          Merge branch 'main' into patch-279

872ea02

github-actions bot commented Jul 1, 2022

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

nijel removed the wontfix label

github-actions bot commented Aug 1, 2022

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

github-actions bot closed this

github-actions bot added the wontfix label

nijel removed the wontfix label

github-actions bot commented Sep 16, 2023

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

orangesunny removed the wontfix label

github-actions bot commented Oct 17, 2023

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

orangesunny removed the wontfix label

github-actions bot commented Nov 18, 2023

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

nijel removed the wontfix label

github-actions bot commented Dec 19, 2023

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added wontfix and removed wontfix labels

github-actions bot commented Jan 19, 2024

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

orangesunny removed the wontfix label

github-actions bot commented Feb 19, 2024

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label


          Merge branch 'main' into patch-279

58f8177

github-actions bot removed the wontfix label

github-actions bot commented Mar 21, 2024

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added wontfix and removed wontfix labels

github-actions bot commented Apr 21, 2024

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added the wontfix label

orangesunny removed the wontfix label

github-actions bot commented May 22, 2024

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

github-actions bot added wontfix and removed wontfix labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment