Docs: Access control documentation reworked 2.5 #5723

comradekingu · 2021-03-22T23:16:37Z

to automate inclusion of all languages or projects.

into where?

Delete existing translations [`Administr

Single strings or entire translations at once?

Add several languages for translation [`Administration

Why "several" is it bulk-addition as opposed to clicking through one-by one in the user UI?

This role ensures all users visibility of public projects.
By default, all users are members of this group.

How is a role a group? Need to get all the cursory logic established up top. (and then note to self read through with that understanding (that I don't have)).

Managers
Group for administrators.

Is it "superusers", (which I seem to think is what I call "site-wide administrators")
The whole "manage/rs", "objects". It is all a bit much all at once.

comradekingu · 2021-03-22T23:17:51Z

docs/admin/access.rst

 Administration
-    Includes all permissions available for the project.
+    All available permissions for the project.


Including adding people that can add administrators?
Should this be site-wide administration? What I am asking is if "superuser" is above this?

This is only at project level - it grants all permissions for the project.

comradekingu · 2021-03-22T23:18:19Z

docs/admin/access.rst


 Languages
-    Can manage translated languages (add or remove translations).
+    Manage translated languages (add or remove translations).


Individual strings or entire languages?

comradekingu · 2021-03-22T23:19:52Z

docs/admin/access.rst

-By default this prevents Weblate from granting access provided by
-`Users` and `Viewers` :ref:`default groups <default-groups>` due to these groups’
-own configuration. This doesn’t prevent you from granting permissions to those
-projects site-wide by altering default groups, creating a new one, or creating


Note to self: wasn't this already not possible?

comradekingu · 2021-03-22T23:20:19Z

docs/admin/access.rst

-groups. For example, you may want to give a permission to manage screenshots to all
-the `Users`.
+Additional permissions can be granted to the default
+groups. In this example the ability manage screenshots for all `Users`.


Example needed

comradekingu · 2021-03-22T23:21:19Z

docs/admin/access.rst

-by site-wide or per-project groups by adding another custom group.
+Dedicated groups to manage permissions for languages, components, and projects
+can be created. These groups can only grant additional privileges that can not
+revoke any permission granted by site-wide or per-project groups by adding another


Granted which permissions, to whom, for what entity?

for more information, see https://pre-commit.ci

comradekingu · 2021-03-22T23:23:04Z

docs/admin/access.rst

@@ -4,32 +4,32 @@ Access control
 ==============

 Weblate comes with a fine-grained privilege system to assign user permissions
-for the whole instance, or in a limited scope.
+for the whole instance with predefined roles, or by assigning one or more
+groups of permissions to users for everything, or individual projects, components,


This needs to be a cursory overview.
Otherwise the whole thing is a riddle where the reader has to establish the connections.
Suggestions welcome :)

codecov · 2021-03-23T00:57:54Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6aee586) 90.82% compared to head (0f6ff75) 90.78%.
Report is 275 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5723      +/-   ##
==========================================
- Coverage   90.82%   90.78%   -0.04%     
==========================================
  Files         554      559       +5     
  Lines       57306    57534     +228     
  Branches     9122     9180      +58     
==========================================
+ Hits        52046    52235     +189     
- Misses       3640     3670      +30     
- Partials     1620     1629       +9

see 51 files with indirect coverage changes

docs/admin/access.rst

for more information, see https://pre-commit.ci

docs/admin/access.rst

github-actions · 2021-05-03T01:57:30Z

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

comradekingu · 2021-05-03T12:15:55Z

docs/admin/access.rst

+- Otherwise, adding any :guilabel:`Projects` to a group (either by directly
+  listing them or by having :guilabel:`Selected projects` set to :guilabel:`All
+  public`) grants the group permissions for the projects. (Effectively
+  the same permissions as being granted access to :ref:`unrestricted components <component-restricted>`


Didn't look into what "which effectively grants the same permissions to access all projects" from the merge error means. Otherwise rewritten from what it was.

comradekingu · 2021-05-03T12:18:13Z

Neverstale

github-actions · 2021-06-25T01:50:27Z

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

Justman100 · 2024-02-19T02:45:22Z

What here now?

nijel · 2024-02-19T10:20:31Z

@Justman100 Somebody needs to review this to verify it doesn't change the meaning of the documentation what has happened in the past. The typical reason for that is that the original documentation isn't clear enough and when reworking, another meaning is chosen than was originally intended.

That's why several of these “reworked documentation” pull requests are stuck. These are big, what makes them challenging to review at once and GitHub is not really helpful in doing iterative review/merge.

nijel · 2024-02-19T10:35:11Z

docs/admin/access.rst

@@ -63,20 +65,18 @@ project.

 .. image:: /screenshots/project-access.webp

-The default value can be changed by :setting:`DEFAULT_ACCESS_CONTROL`.
+Access mode can also be changed by setting :setting:`DEFAULT_ACCESS_CONTROL`.


This only changes the default value for newly created projects.

nijel · 2024-02-19T10:37:22Z

docs/admin/access.rst

-    Your project name and other information can’t be revealed through this.
+    `Private` projects still expose counts for all projects in their
+    respective statistics and language summary.
+    This does not reveal project name or other info.


This makes it IMHO less clear. The intention is to make clear that even private projects are reflected in site-wide statistics, such as global or language ones.

nijel · 2024-02-19T10:37:52Z

docs/admin/access.rst

@@ -97,47 +97,57 @@ The following teams are automatically created for every project:

 For `Public`, `Protected` and `Private` projects:

+Granting users :guilabel:`Manage project access` (see :ref:`privileges`)
+gives them access to assign other users in Public`, `Protected` and
+`Private` (but not `Custom`) projects to one of the following groups:


This is duplicated few lines above.

docs/admin/access.rst

Justman100 · 2024-02-19T18:58:57Z

@comradekingu

comradekingu · 2024-02-19T23:25:39Z

docs/admin/access.rst


-The following teams are automatically created for every project:
+Granting users :guilabel:`Manage project access` (see :ref:`privileges`)


I would argue it doesn't need to be pointed out that users need to have MPA to do what is explained to be recursive about MPA.
My original intent must have been to replace the duplicated text, and then I didn't remove the original one.
Maybe it makes sense now, but not at all sure.

Some of the text is moved to a hint below.

docs/admin/access.rst

Co-authored-by: Allan Nordhøy <epost@anotheragency.no>

github-actions · 2024-03-25T01:48:33Z

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

Justman100 · 2024-03-25T08:50:42Z

@comradekingu

What here now?

orangesunny · 2024-03-25T10:52:12Z

What here now?

A review is needed. @comradekingu did his work, now I need to find time to go through it. As the PR is long with many changes, I needed to postpone it multiple times. Short PRs get merged quicker.

docs/admin/access.rst

github-actions · 2024-04-25T01:49:19Z

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

Justman100 · 2024-05-03T09:32:30Z

@nijel @comradekingu

Docs: Access control documentation reworked 2.5

203f626

comradekingu commented Mar 22, 2021

View reviewed changes

[pre-commit.ci] auto fixes from pre-commit.com hooks

1e80295

for more information, see https://pre-commit.ci

comradekingu commented Mar 22, 2021

View reviewed changes

nijel reviewed Mar 23, 2021

View reviewed changes

docs/admin/access.rst Outdated Show resolved Hide resolved

nijel requested a review from a team March 23, 2021 06:16

comradekingu and others added 2 commits March 23, 2021 08:41

First pass complete

e43aee4

[pre-commit.ci] auto fixes from pre-commit.com hooks

0a0adb9

for more information, see https://pre-commit.ci

Base automatically changed from master to main March 23, 2021 12:16

comradekingu mentioned this pull request Mar 25, 2021

Docs: Installation documentation reworked #5740

Closed

6 tasks

nijel assigned orangesunny Mar 26, 2021

comradekingu commented Mar 28, 2021

View reviewed changes

docs/admin/access.rst Outdated Show resolved Hide resolved

Spelling: editing built-in roles not possible, lost when upgrading

585c3d4

comradekingu commented Mar 28, 2021

View reviewed changes

docs/admin/access.rst Outdated Show resolved Hide resolved

Spelling: - Custom changes are not lost

9c66b5d

github-actions bot added the wontfix Nobody will work on this. label May 3, 2021

Merge branch 'main' into patch-249

ed5d761

comradekingu commented May 3, 2021

View reviewed changes

github-actions bot removed the wontfix Nobody will work on this. label May 4, 2021

Merge branch 'main' into patch-249

2b2bc8a

github-actions bot added the wontfix Nobody will work on this. label Jun 25, 2021

nijel removed the wontfix Nobody will work on this. label Jun 29, 2021

github-actions bot removed the wontfix Nobody will work on this. label Jan 22, 2024

Merge branch 'main' into patch-249

506895f

nijel reviewed Feb 19, 2024

View reviewed changes

docs/admin/access.rst Outdated Show resolved Hide resolved

Update docs/admin/access.rst

0f6ff75

Requested changes made

bdccb18

comradekingu commented Feb 19, 2024

View reviewed changes

docs/admin/access.rst Outdated Show resolved Hide resolved

Update docs/admin/access.rst

d527997

Co-authored-by: Allan Nordhøy <epost@anotheragency.no>

github-actions bot added the wontfix Nobody will work on this. label Mar 25, 2024

orangesunny removed the wontfix Nobody will work on this. label Mar 25, 2024

Merge branch 'main' into patch-249

7977588

nijel reviewed Mar 25, 2024

View reviewed changes

docs/admin/access.rst Outdated Show resolved Hide resolved

Update docs/admin/access.rst

0084eba

nijel reviewed Mar 25, 2024

View reviewed changes

docs/admin/access.rst Outdated Show resolved Hide resolved

Update docs/admin/access.rst

d5134c9

nijel reviewed Mar 25, 2024

View reviewed changes

docs/admin/access.rst Show resolved Hide resolved

Update docs/admin/access.rst

926ce97

github-actions bot added the wontfix Nobody will work on this. label Apr 25, 2024

orangesunny removed the wontfix Nobody will work on this. label Apr 25, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Docs: Access control documentation reworked 2.5 #5723

Docs: Access control documentation reworked 2.5 #5723

comradekingu commented Mar 22, 2021 •

edited

comradekingu Mar 22, 2021

nijel Mar 23, 2021

comradekingu Mar 22, 2021 •

edited

comradekingu Mar 22, 2021

comradekingu Mar 22, 2021

comradekingu Mar 22, 2021 •

edited

comradekingu Mar 22, 2021 •

edited

codecov bot commented Mar 23, 2021 •

edited

github-actions bot commented May 3, 2021

comradekingu May 3, 2021

comradekingu commented May 3, 2021 •

edited

github-actions bot commented Jun 25, 2021

Justman100 commented Feb 19, 2024

nijel commented Feb 19, 2024

nijel Feb 19, 2024

nijel Feb 19, 2024

nijel Feb 19, 2024

Justman100 commented Feb 19, 2024

comradekingu Feb 19, 2024

github-actions bot commented Mar 25, 2024

Justman100 commented Mar 25, 2024

orangesunny commented Mar 25, 2024

github-actions bot commented Apr 25, 2024

Justman100 commented May 3, 2024


		The following teams are automatically created for every project:
		Granting users :guilabel:`Manage project access` (see :ref:`privileges`)

Docs: Access control documentation reworked 2.5 #5723

Are you sure you want to change the base?

Docs: Access control documentation reworked 2.5 #5723

Conversation

comradekingu commented Mar 22, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

comradekingu Mar 22, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

comradekingu Mar 22, 2021 • edited

Choose a reason for hiding this comment

comradekingu Mar 22, 2021 • edited

Choose a reason for hiding this comment

codecov bot commented Mar 23, 2021 • edited

Codecov Report

github-actions bot commented May 3, 2021

Choose a reason for hiding this comment

comradekingu commented May 3, 2021 • edited

github-actions bot commented Jun 25, 2021

Justman100 commented Feb 19, 2024

nijel commented Feb 19, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Justman100 commented Feb 19, 2024

Choose a reason for hiding this comment

github-actions bot commented Mar 25, 2024

Justman100 commented Mar 25, 2024

orangesunny commented Mar 25, 2024

github-actions bot commented Apr 25, 2024

Justman100 commented May 3, 2024

comradekingu commented Mar 22, 2021 •

edited

comradekingu Mar 22, 2021 •

edited

comradekingu Mar 22, 2021 •

edited

comradekingu Mar 22, 2021 •

edited

codecov bot commented Mar 23, 2021 •

edited

comradekingu commented May 3, 2021 •

edited