New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Add-on activity log #11080
base: main
Are you sure you want to change the base?
Conversation
b7f3f4d
to
f656020
Compare
What is the criterion for pruning and how we plan to do this?
|
Have a periodic task for that, something similar like we do for an audit log: weblate/weblate/accounts/tasks.py Lines 38 to 45 in f61fea6
|
a3b49fd
to
06b3001
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd display the activity log on the add-on detail page, not on the list page. On the list page, all add-ons logs would be mixed up, what could make reading the log challenging with many add-ons installed.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11080 +/- ##
==========================================
- Coverage 90.82% 90.62% -0.20%
==========================================
Files 554 572 +18
Lines 57306 58708 +1402
Branches 9122 9375 +253
==========================================
+ Hits 52046 53203 +1157
- Misses 3640 3817 +177
- Partials 1620 1688 +68
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, the only missing bit is ability to display log for add-ons which have no configuration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add test for the new view?
2343347
to
271cc0b
Compare
|
||
self.assertEqual(response.status_code, 200) | ||
self.assertTemplateUsed(response, "addons/addon_logs.html") | ||
self.assertEqual(response.context["instance"], addon) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have tests that the request for logs fails without authentication?
Proposed changes
closes #10053
Add AddonActivityLog model
Checklist