component: Improve duplication of components #11079
Conversation
ParthS007
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11079 +/- ##
==========================================
- Coverage 90.82% 90.74% -0.08%
==========================================
Files 554 559 +5
Lines 57306 57618 +312
Branches 9122 9200 +78
==========================================
+ Hits 52046 52285 +239
- Misses 3640 3696 +56
- Partials 1620 1637 +17
|
ParthS007
force-pushed
the
10896
branch
4 times, most recently
from
a29f54e
to
18ec295
Compare
|
This pull request has been automatically marked as stale because there wasn’t any recent activity. It will be closed soon if no further action occurs. Thank you for your contributions! |
| @@ -96,6 +96,7 @@ | |||
| <li><a href="{% url 'manage-access' project=object.project.slug %}">{% trans "Users" %}</a></li> | |||
| {% endif %} | |||
| {% if user_can_edit_component %} | |||
| <li><a href="{% url 'create-component' %}#existing">{% trans "Duplicate Component" %}</li> | |||
There was a problem hiding this comment.
I'd expect the current component to be selected when clicking on the link here.
There was a problem hiding this comment.
Okay, To have initial value for component field in get_form, where I can set initial of form in fetch_params from the request?
form.fields['component'].initial = form.initial.get('component')
| delete_message=component.delete_message, | ||
| merge_message=component.merge_message, | ||
| addon_message=component.addon_message, | ||
| pull_message=component.pull_message, |
There was a problem hiding this comment.
While you include these in the URL, there is nothing to process these (ComponentCreateForm doesn't accept these). The additional fields either should be hidden inputs in the create form, or it should have tabs/folding for the additional parameters.
Proposed changes
closes #10896
Checklist