Glossary: Add context to glossary form and change permission check

[Xzonn]

Proposed changes

Add an input box for context to glossary form in the translation UI (#10969), based on NewMonolingualUnitForm:

weblate/weblate/trans/forms.py

Lines 2375 to 2391 in 8f105d7

	class NewMonolingualUnitForm(NewUnitBaseForm):
	context = forms.CharField(
	label=gettext_lazy("Translation key"),
	help_text=gettext_lazy(
	"Key used to identify the string in the translation file. "
	"File-format specific rules might apply."
	),
	required=True,
	)
	source = PluralField(
	label=gettext_lazy("Source language text"),
	help_text=gettext_lazy(
	"You can edit this later, as with any other string in "
	"the source language."
	),
	required=True,
	)

I also noticed that there is a significant difference between NewMonolingualUnitForm and NewBilingualSourceUnitForm. Should we unify them?

I also changed the permission check from unit.add to glossary.add. Before this commit, terms can not be directly added to the glossary because of this check:

weblate/weblate/auth/permissions.py

Lines 273 to 274 in 4774584

	if not source and template:
	return Denied(gettext("Add the string to the source language instead."))

Checklist

• Lint and unit tests pass locally with my changes.
• I have added tests that prove my fix is effective or that my feature works.
• I have added documentation to describe my feature.
• I have squashed my commits into logic units.
• I have described the changes in the commit messages.

Other information

Screenshot

[nijel]

Can we make it share the code with NewBilingualSourceUnitForm? Duplicating the field description and help texts will lead to them getting out of sync over time.

[Xzonn]

I changed TermForm to inherit NewBilingerGlossaryUnitForm in order to avoid the field description and help texts:

Screenshot

The font size for .highlighted-output should be set to 16px, but I'm not sure which CSS file to add to.

[github-actions]

This pull request has been automatically marked as stale because there wasn’t any recent activity.

It will be closed soon if no further action occurs.

Thank you for your contributions!

[codecov]

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 90.62%. Comparing base (6aee586) to head (994edb7).
Report is 1656 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11063      +/-   ##
==========================================
- Coverage   90.82%   90.62%   -0.21%     
==========================================
  Files         554      570      +16     
  Lines       57306    58599    +1293     
  Branches     9122     9373     +251     
==========================================
+ Hits        52046    53103    +1057     
- Misses       3640     3810     +170     
- Partials     1620     1686      +66     

Files	Coverage Δ
weblate/glossary/tests.py	100.00% <ø> (ø)
weblate/glossary/forms.py	74.13% <81.81%> (-1.58%)	⬇️
weblate/trans/forms.py	87.84% <69.23%> (-0.03%)	⬇️

... and 241 files with indirect coverage changes

[nijel]

Merged, thanks for your contribution!