Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment mention autosuggestion #2964

Closed
Kyuuu opened this issue Aug 16, 2019 · 6 comments · Fixed by #4094
Closed

Comment mention autosuggestion #2964

Kyuuu opened this issue Aug 16, 2019 · 6 comments · Fixed by #4094
Assignees
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. ux Issues related to user experience.
Milestone

Comments

@Kyuuu
Copy link
Contributor

Kyuuu commented Aug 16, 2019

Is your feature request related to a problem? Please describe.
When mentioning someone in the comments section it would be helpful to be able to type and select them using a handle, similar to the system used in Discord.

Describe the solution you'd like
mention

Describe alternatives you've considered
//

Additional context
//

@nijel nijel added enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. help wanted Extra attention is needed. ux Issues related to user experience. labels Aug 16, 2019
@nijel nijel added the hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. label Sep 25, 2019
@JanStevcik
Copy link

Hi, can I do this issue?

@nijel
Copy link
Member

nijel commented Oct 9, 2019

Yes, you're welcome to do that.

@nijel nijel changed the title Mention autosuggestion Comment mention autosuggestion Oct 22, 2019
@rhofer
Copy link
Contributor

rhofer commented Mar 5, 2020

When mentioning someone in the comments section it would be helpful to be able to type and select them using a handle, similar to the system used in Discord.

... or similar to github or gitlab when mentioning somebody in e.g. this issue here.

Especially, when social authentication is activated (e.g. via auth0), and e.g. two users are registering with the same first name, this results into:

  • USERNAME 1: Martin
  • USERNAME 2: Martina31bb7cecc0b442c

In the second case, there is no chance to remember the user name, hence autosuggestion is kind of a must.

@nijel
Copy link
Member

nijel commented Apr 2, 2020

@SaptakS When touching the editor, please keep in mind that we want more features there in future.

Related issues I've remembered now:

@nijel nijel added this to To do in Translation editor Apr 12, 2020
@nijel nijel removed hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. labels May 15, 2020
@nijel
Copy link
Member

nijel commented Jun 17, 2020

This could probably use the /api/users/. It should be exteded to support this use case. The django_filters can be added to add filtering and add support for making the API call by non superusers by filtering the available fields to them (probably just username and full_name should be exposed in this case).

@nijel nijel added this to the 4.2 milestone Jul 8, 2020
@nijel nijel linked a pull request Jul 8, 2020 that will close this issue
4 tasks
Translation editor automation moved this from To do to Done Jul 8, 2020
nijel added a commit that referenced this issue Jul 8, 2020
* Adds user suggestions in comment section
* Uses codemirror and show-hint addon to show autocomplete users
* Use markdown mode with show hint over multiple different textarea
* Adds API and selenium tests for user mentions
* Modify some logics for showing user suggestions
* Using async method for showing hint

Fixes #2964

Co-authored-by: Michal Čihař <michal@cihar.com>
@github-actions
Copy link

github-actions bot commented Jul 8, 2020

Thank you for your report, the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, consider supporting Weblate by donating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. ux Issues related to user experience.
Projects
Development

Successfully merging a pull request may close this issue.

5 participants