Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable individual upload of avatar as e.g. png or jpg #3564

Open
rhofer opened this issue Mar 5, 2020 · 3 comments
Open

Enable individual upload of avatar as e.g. png or jpg #3564

rhofer opened this issue Mar 5, 2020 · 3 comments
Labels
enhancement Adding or requesting a new feature.

Comments

@rhofer
Copy link
Contributor

rhofer commented Mar 5, 2020

Besides the gravatar.com integration, it would be great to allow individual upload of a picture to be set as avatar (similar to e.g. github or gitlab user profile settings)

  1. navigate to ../accounts/profile/#profile of your weblate instance
  2. In section Your avatar provide a file dialogue to upload an avatar from your local disk
    • provide and enforce size limits (e.g. pixel size or in kB)
  3. Store uploaded picture in database (not in local file system as e.g. media)

Fallback: in case there is no individual picture uploaded, still use gravatar.com as fall back.

In relation to #2964 this would also help to identify a desired user when mentioning in comment function.

@nijel nijel added the enhancement Adding or requesting a new feature. label Mar 5, 2020
@nijel
Copy link
Member

nijel commented Mar 5, 2020

I think it should be stored in the file system same as we do with other things (for example screenshots). I currently don't see any benefits in putting this into database. Weblate will require filesystem for forseable future and in case this is going to change, migrating images to database is pretty easy.

@nijel
Copy link
Member

nijel commented Mar 6, 2020

When touching this part, it should be made more flexible:

I think the workflow should be:

  • Upon registration whatever is available is used (in order: from the authentication provider, Libravatar, Gravatar)
  • User can choose out of avatars from available providers (for example in case he has more authentication methods having avatar)
  • Additional option for user uploaded avatar

@rhofer
Copy link
Contributor Author

rhofer commented Mar 6, 2020

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adding or requesting a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants