Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues when duplicating a component #10896

Open
nikclayton opened this issue Jan 30, 2024 · 3 comments · May be fixed by #11079
Open

Issues when duplicating a component #10896

nikclayton opened this issue Jan 30, 2024 · 3 comments · May be fixed by #11079
Assignees
@ParthS007
Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.

Comments

@nikclayton
Copy link

Describe the problem

Creating a component that's a copy of another component feels more difficult than it needs to be.

Describe the solution you would like

  1. It's not obvious that a component can be duplicated. When viewing a component there's no option to duplicate it. You have to create a new component, and choose the option to base the new component on an existing component. This is not discoverable and quite surprising.
  2. The new component does not duplicate key settings from the source component. In my testing so far the settings that are not duplicated are at least:
    a. The license
    b. The contributor agreement text
    c. The commit messages

These all have to be manually copied from an existing component to the new component.

I'd make it more obvious that duplication is possible with a copy icon (e.g,. something like https://www.flaticon.com/free-icon/copy_126498?term=copy&page=1&position=2&origin=tag&related_id=126498) next to the existing "browse" icon.

The lack of duplication of the other settings feels like a bug.

Describe alternatives you have considered

No response

Screenshots

No response

Additional context

No response
@nijel
Copy link
Member

nijel commented Jan 30, 2024

Indeed, only a few of the settings are currently cloned:

weblate/weblate/trans/views/create.py

Lines 516 to 524 in 3ce0a3d

if self.origin == "existing":
return self.redirect_create(
repo=component.get_repo_link_url(),
project=component.project.pk,
name=form.cleaned_data["name"],
slug=form.cleaned_data["slug"],
vcs=component.vcs,
source_language=component.source_language.pk,
)

More of them can definitely be added.

@nijel nijel added enhancement Adding or requesting a new feature. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed. good first issue Opportunity for newcoming contributors. labels Jan 30, 2024
@github-actions GitHub Actions
Copy link

This issue seems to be a good fit for newbie contributors. You are welcome to contribute to Weblate! Don't hesitate to ask any questions you would have while implementing this.

You can learn about how to get started in our contributors documentation.

@ParthS007 ParthS007 self-assigned this Feb 22, 2024
@ParthS007 ParthS007 linked a pull request Feb 22, 2024 that will close this issue
Open
5 tasks
@ParthS007
Copy link
Member

@nijel I've included the requested information in duplication in #11079. Let me know if there's any other attribute that should be included for duplication.

Regarding the duplication functionality, should we consider showing the duplicate icon from the all components list page of a project? If so, what specific functionalities and attributes should be included in the duplication process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ParthS007 ParthS007

Labels
enhancement Adding or requesting a new feature. good first issue Opportunity for newcoming contributors. hacktoberfest This is suitable for Hacktoberfest. Don’t try to spam. help wanted Extra attention is needed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

component: Improve duplication of components ParthS007/weblate
3 participants
@nijel @nikclayton @ParthS007