Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify the two ways of adding glossary terms #10969

Closed
tjhietala opened this issue Feb 9, 2024 · 3 comments · Fixed by #11063
Closed

Unify the two ways of adding glossary terms #10969

tjhietala opened this issue Feb 9, 2024 · 3 comments · Fixed by #11063
Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Milestone
5.6

Comments

@tjhietala
Copy link
Contributor

Describe the problem

Currently Weblate has two UIs for adding glossary terms:

  1. From the translation view, by clicking "Add term to glossary"
  2. From the glossary overview, by clicking "Add new glossary term"

The UIs that open are similar in terms of content (most of the fields are the same) but not identical. In the first case, there's a text field called "Explanation" and a menu for selecting the glossary to add the term to. In the second case, there's a text field called "Key"(TDF Weblate 5.3.1) or "Context" (current Hosted Weblate) 5. and additionally some buttons for inserting special characters.

It's not clear whether "Explanation" is the same field as "Key"/"Context".

Describe the solution you would like

It would be better to unify the layouts and terminology as much as possible or even better, remove one of the UI altogether to avoid user confusion and simplify code maintenance.

Describe alternatives you have considered

No response

Screenshots

No response

Additional context

No response
@tjhietala
Copy link
Contributor Author

Also, in the second UI, there's a checkbox titled "Auto-adjust context when an identical string already exists." which doesn't exist in the first UI and does not seem to be explained in Weblate's documentation.

@nijel nijel added enhancement Adding or requesting a new feature. ux Issues related to user experience. labels Feb 12, 2024
@nijel nijel added this to the 5.4 milestone Feb 12, 2024
@comradekingu
Copy link
Contributor

In that line of thinking, unifying things into adding glossary terms from the translation field would help?

@nijel nijel modified the milestones: 5.4, 5.5 Feb 13, 2024
nijel added a commit to nijel/weblate that referenced this issue Feb 13, 2024
@nijel
component: consolidate add to glossary label
ce70db9 
See WeblateOrg#10969
nijel added a commit that referenced this issue Feb 13, 2024
@nijel
component: consolidate add to glossary label
1cdbfcb 
See #10969
@Xzonn Xzonn mentioned this issue Feb 21, 2024
Merged
5 tasks
@nijel nijel modified the milestones: 5.5, 5.6 Apr 17, 2024
@nijel nijel linked a pull request May 7, 2024 that will close this issue
Glossary: Add context to glossary form and change permission check #11063
Merged
5 tasks
@github-actions GitHub Actions
Copy link

Thank you for your report; the issue you have reported has just been fixed.

  • In case you see a problem with the fix, please comment on this issue.
  • In case you see a similar problem, please open a separate issue.
  • If you are happy with the outcome, don’t hesitate to support Weblate by making a donation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Adding or requesting a new feature. ux Issues related to user experience.
Projects
None yet
Milestone
5.6
Development

Successfully merging a pull request may close this issue.

Glossary: Add context to glossary form and change permission check Xzonn/weblate
3 participants
@nijel @tjhietala @comradekingu