Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Updates #857

Merged
merged 3 commits into from May 10, 2022
Merged

Dependency Updates #857

merged 3 commits into from May 10, 2022

Conversation

oliverharrison
Copy link
Contributor

No issue.

DESCRIPTION

SCREENSHOTS

Build:
image

Lint:
image

OTHER

  • [] Is this issue accessible? (Section 508/WCAG 2.0AA)
  • Does this issue pass all the linting? (PHPCS, ESLint, SassLint)
  • [] Does this pass CBT?

STEPS TO VERIFY

Pull, Build, Lint. Check the frontend for anomalies.

@oliverharrison oliverharrison changed the title Dependabot Updates Dependency Updates May 9, 2022
@coreymcollins
Copy link
Contributor

This looks good – also, to note, sourcemaps still do work with these updates. Sourcemaps are created in dev mode, so when running start or watch, but not when running build. This is determined by the NODE_ENV setting in our scripts.

@coreymcollins coreymcollins merged commit 258dbc9 into main May 10, 2022
@coreymcollins coreymcollins deleted the feature/dependabot-updates-may9 branch May 10, 2022 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants