Fixed bug with WAV file wrongly parsed as MP3 #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed MP3 priority from 99 to 101 - Added a preventive check against WAV headers in the MP3 parser - Added a new test that ensures we correctly parse files over HTTP even when not providing a filename hint - Added a test verifying that MP3 is always the last parser used when not providing a filename hint - Updated some fixture names
rcpalacio
reviewed
Aug 23, 2023
rcpalacio
reviewed
Aug 23, 2023
rcpalacio
reviewed
Aug 23, 2023
rcpalacio
reviewed
Aug 23, 2023
linkyndy
reviewed
Aug 23, 2023
Co-authored-by: Andrei Horak <linkyndy@gmail.com>
linkyndy
reviewed
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened when parsing files without passing a filename hint, hence relying only on the file bytes. The MP3 format is loose and the MP3 parser is prone to false positives, but hopefully the following fixes will prevent this from happening for any of the file types for which we have registered parsers.