Simplifying test setup. Ditching fixture in favor of expliciting asse…

…mbling the error scenario in code
WeTransfer · Sep 14, 2023 · 916b1cb · 916b1cb
1 parent b713c05
commit 916b1cb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/spec/fixtures/MP4/invalid/inconsistent_ftyp_box.mp4 b/spec/fixtures/MP4/invalid/inconsistent_ftyp_box.mp4
diff --git a/spec/parsers/mp4_parser_spec.rb b/spec/parsers/mp4_parser_spec.rb
@@ -31,10 +31,11 @@
       end
     end
 
-    context "when the 'ftyp' box can't be parsed" do
+    context "when when magic bytes are present but the 'ftyp' box can't be parsed" do
       let(:result) do
-        path = fixtures_dir + '/MP4/invalid/inconsistent_ftyp_box.mp4'
-        subject.call(File.open(path, 'rb'))
+        input = [0xFF].pack('N') + 'ftyp' + 'avc1 ' + [0x1].pack('N')
+        io = StringIO.new(input)
+        subject.call(io)
       end
 
       it 'should be nil' do