fix: session approval accounts order #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
9 Ignored Deployments
|
1. expected order of accounts is smart accounts followed by EOA's 2. supportedAddressPriority will now only return the address of smart account.
ganchoradkov
requested changes
May 13, 2024
| // reorderedEip155Accounts includes Smart Accounts(if enabled) and EOA's | ||
| namespaces.eip155.accounts = reorderedEip155Accounts | ||
| // we should append the smart accounts to the available eip155 accounts | ||
| namespaces.eip155.accounts = reorderedEip155Accounts.concat(namespaces.eip155.accounts) |
There was a problem hiding this comment.
Suggested change
| namespaces.eip155.accounts = reorderedEip155Accounts.concat(namespaces.eip155.accounts) | |
| namespaces.eip155.accounts = [...new Set(reorderedEip155Accounts.concat(namespaces.eip155.accounts))] |
this will remove any duplicates from the array
There was a problem hiding this comment.
Fixed this by modifying the supportedAddressPriority method to return only the smart account address on supported chain for enabled SA. Will not need this as now no duplication will occur.
arein
requested changes
May 13, 2024
ganchoradkov
approved these changes
May 14, 2024
arein
approved these changes
May 22, 2024
|
issue #557 fix included |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverting to previous solution as suggested.