Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Astar zKatana testnet #415

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

codespool
Copy link

  • Add Astar zKatana chain data to
    • react-dapp-v2
    • react-dapp-v2-with-ethers
    • react-dapp-v2-with-web3js

Modify EIP155Colors, EIP155ChainData, EIP155Metadata objects, and add logo image to ./public/assets

Copy link

vercel bot commented Jan 16, 2024

@codespool is attempting to deploy a commit to the WalletConnect Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-dapp-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 0:52am
2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
react-dapp-v2-with-ethers ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 0:52am
react-dapp-v2-with-web3js ⬜️ Ignored (Inspect) Visit Preview Jan 17, 2024 0:52am

Copy link
Member

@bkrem bkrem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for adding zKatana to the sample dapps 🙏

All looks good to me on that side of the equation, but we're currently missing support on the sample wallet side (see screenshot).

Since this is an EIP155/EVM chain, adding it to the wallet should be just as simple. Here's an example from when the zkSync team added support to the wallet: #211

Screenshot 2024-01-17 at 14 31 19

@bkrem
Copy link
Member

bkrem commented Jan 17, 2024

Adding @glitch-txs and @ganchoradkov as co-reviewers for visibility

@codespool
Copy link
Author

Hi @bkrem , sorry for the delay.
Added the zKatana config to wallet packages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants