Resolve unwrap in build body and when acquiring RwLock #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
threema-donat
force-pushed
the
resolve_unwrap_in_build_body
branch
from
f53b6c3
to
4b432fa
Compare
|
Curious: why not use tokio's |
chris13524
reviewed
Apr 24, 2024
CHANGELOG.md
Outdated
| @@ -1,5 +1,9 @@ | |||
| # Changelog | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| - fix: Avoid panics when acquiring a RwLock<_> and when building HTTP requests | |||
There was a problem hiding this comment.
Looks like breaking change; we should bump to 0.7.0. I will do after merging
The maintainers of tokio itself say that one should not use the async version of Mutex / RwLock without having reason for that: link. The same can very likely also be said about RwLock. For this reason, I think it's better to use parking_lot. |
|
Please resolve conflicts :) |
- Add error::Error variant - Add test for an invalid request
threema-donat
force-pushed
the
resolve_unwrap_in_build_body
branch
from
4b432fa
to
8fabb9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current version does panic if a RwLock is poisoned and also when a HTTP request could not be constructed from the given user data.
This PR replaces the RwLocks with the ones from parking_lot that do not have poison errors and adds propagation of errors happening when building the http request.
Resolves #69
How Has This Been Tested?
A test has been written for the invalid payload.
Due Dilligence