Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/deserialize and certificate parts (#3) #64

Merged
merged 7 commits into from Dec 22, 2022

Conversation

jrconlin
Copy link
Contributor

Description

  • Derive Deserialize for APS and sub-structs
  • Add Client::certificate_parts to support more use cases
  • Fix stack-overflow in Error's Display impl Also removed some deprecated impls and changed the "reason" string from the debug string to the human-readable message.
  • Bump to v0.6.2
  • Migrate to new maintainers
  • fix: Adds tcp feature to hyper (Add "tcp" feature to Hyper #61)

Co-authored-by: Mark Drobnak mdrobnak@mozilla.com

How Has This Been Tested?

includes unit tests, integration with CircleCI

Due Dilligence

  • Breaking change
  • Requires a documentation update
  • Requires a e2e/integration test update

* Derive Deserialize for APS and sub-structs
* Add Client::certificate_parts to support more use cases
* Fix stack-overflow in Error's Display impl
  Also removed some deprecated impls and changed the "reason" string from
  the debug string to the human-readable message.

* Bump to v0.6.2
* Migrate to new maintainers
* fix: Adds tcp feature to hyper (WalletConnect#61)

Co-authored-by: Mark Drobnak <mdrobnak@mozilla.com>
Co-authored-by: Julius de Bruijn <bruijn@prisma.io>
Co-authored-by: Julius de Bruijn <julius+github@nauk.io>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rich Neswold <neswold@fnal.gov>
Co-authored-by: Alex Hortopan <alex@hortopan.com>
Co-authored-by: Harry Bairstow <h.bairstow22@gmail.com>
Co-authored-by: Austin Evans <austinjevans@me.com>
@HarryET HarryET changed the base branch from master to v0.7 December 21, 2022 11:05
Copy link
Contributor

@HarryET HarryET left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good, I'll fix any conflicts and merge

@HarryET HarryET changed the base branch from v0.7 to master December 22, 2022 13:56
@HarryET
Copy link
Contributor

HarryET commented Dec 22, 2022

Looks like I got all the changes that hadn't been done some how, feel free to let me know if I missed any was a bit of a mess to try merge after #63 & #62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants