Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add implementation to support safari web push #57

Merged
merged 3 commits into from Nov 5, 2021

Conversation

hortopan
Copy link
Contributor

@hortopan hortopan commented Nov 4, 2021

  • Added support for safari web push.

https://developer.apple.com/library/archive/documentation/NetworkingInternet/Conceptual/NotificationProgrammingGuideForWebsites/PushNotifications/PushNotifications.html

{
 "aps": {
    "alert": {
        "title": "Flight A998 Now Boarding",
        "body": "Boarding has begun for Flight A998.",
        "action": "View"
    },
 "url-args": ["arg1", "arg2"]
 }
}

@pimeys
Copy link
Contributor

pimeys commented Nov 4, 2021

Cool. Is this something that also could be done with https://github.com/pimeys/rust-web-push

I will merge this if you feel it's important to have here, but I have no means to test any of the code...

@hortopan
Copy link
Contributor Author

hortopan commented Nov 4, 2021

Cool. Is this something that also could be done with https://github.com/pimeys/rust-web-push

Safari's web push is not based on web push protocol (with web workers, etc) so it doesn't work with regular web pushes as everything needs to go through Apple's apns.

I think this could potentially be implemented as a dependency within pimeys/rust-web-push so that we have support across the board.

src/request/notification/web.rs Outdated Show resolved Hide resolved
src/request/notification/web.rs Outdated Show resolved Hide resolved
@hortopan hortopan requested a review from pimeys November 4, 2021 22:52
@pimeys pimeys merged commit da596b6 into WalletConnect:master Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants