Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pluralize form-factors header/property #358

Merged
merged 1 commit into from
Mar 7, 2024

Conversation

djmitche
Copy link
Contributor

@djmitche djmitche commented Mar 6, 2024

Since form-factors are now represented as a list, the header and property names should be plural, as mentioned in #355.


Preview | Diff

@arichiv
Copy link
Collaborator

arichiv commented Mar 7, 2024

What's the usage on this and has it launched officially for any browser?

@djmitche
Copy link
Contributor Author

djmitche commented Mar 7, 2024

It has not launched officially for any browser. It is in dev trials in Chrome, where it is not enabled for any groups: https://chromestatus.com/feature/5162545698045952.

Copy link
Collaborator

@miketaylr miketaylr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thx

@miketaylr miketaylr merged commit 9b424db into WICG:main Mar 7, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Mar 7, 2024
SHA: 9b424db
Reason: push, by miketaylr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants